Microsoft defender for cloud collector #23631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'origin/master' into Microsoft_Defender_For_Cloud_Collector
Merge remote-tracking branch 'origin/master' into Microsoft_Defender_For_Cloud_Collector
Merge branch 'master' of github.com:demisto/content into Microsoft_Defender_For_Cloud_Collector
gal-forer
suggested changes
Apr 10, 2023
Comment on lines
65
to
68
| if check_events_were_filtered_out(curr_events, curr_filtered_events): | ||
| events.extend(curr_filtered_events) | ||
| break | ||
| events.extend(curr_filtered_events) |
There was a problem hiding this comment.
Suggested change
| if check_events_were_filtered_out(curr_events, curr_filtered_events): | |
| events.extend(curr_filtered_events) | |
| break | |
| events.extend(curr_filtered_events) | |
| events.extend(curr_filtered_events) | |
| if check_events_were_filtered_out(curr_events, curr_filtered_events): | |
| break |
There was a problem hiding this comment.
nice suggestion done.
...egrations/MicrosoftDefenderForCloudEventCollector/MicrosoftDefenderForCloudEventCollector.py
Show resolved
Hide resolved
...egrations/MicrosoftDefenderForCloudEventCollector/MicrosoftDefenderForCloudEventCollector.py
Show resolved
Hide resolved
| @@ -0,0 +1,50 @@ | |||
| XSIAM collector for Microsoft Defender for Cloud alerts. | |||
| This integration was integrated and tested with version xx of Microsoft Defender for Cloud Event Collector | |||
There was a problem hiding this comment.
Replace the xx with a real version
There was a problem hiding this comment.
deleted this line.
Comment on lines
12
to
20
| | Microsoft Azure Management URL | | False | | ||
| | ID | | True | | ||
| | Token | | True | | ||
| | Key | | True | | ||
| | Certificate Thumbprint | Used for certificate authentication. As appears in the "Certificates & secrets" page of the app. | False | | ||
| | Private Key | Used for certificate authentication. The private key of the registered certificate. | False | | ||
| | Subscription ID to use | | True | | ||
| | Trust any certificate (not secure) | | False | | ||
| | Use system proxy settings | | False | |
There was a problem hiding this comment.
This is auto-generated from the yml added description where it is not self-explanatory.
...urityCenter/Integrations/MicrosoftDefenderForCloudEventCollector/test_data/AlertsToSort.json
Show resolved
Hide resolved
...urityCenter/Integrations/MicrosoftDefenderForCloudEventCollector/test_data/AlertsToSort.json
Show resolved
Hide resolved
gal-forer
approved these changes
Apr 27, 2023
Merge remote-tracking branch 'origin/master' into Microsoft_Defender_For_Cloud_Collector
Merge branch 'Microsoft_Defender_For_Cloud_Collector' of github.com:demisto/content into Microsoft_Defender_For_Cloud_Collector
Merge remote-tracking branch 'origin/master' into Microsoft_Defender_For_Cloud_Collector
DeanArbel
approved these changes
May 24, 2023
There was a problem hiding this comment.
Looks good. Good job, I know it's been a bumpy road.
@ShirleyDenkberg Please review this PR, take special attention to the Known Limitation section.
...crosoftDefenderForCloudEventCollector/MicrosoftDefenderForCloudEventCollector_description.md
Outdated
Show resolved
Hide resolved
...crosoftDefenderForCloudEventCollector/MicrosoftDefenderForCloudEventCollector_description.md
Outdated
Show resolved
Hide resolved
...crosoftDefenderForCloudEventCollector/MicrosoftDefenderForCloudEventCollector_description.md
Outdated
Show resolved
Hide resolved
Packs/AzureSecurityCenter/Integrations/MicrosoftDefenderForCloudEventCollector/README.md
Outdated
Show resolved
Hide resolved
Packs/AzureSecurityCenter/Integrations/MicrosoftDefenderForCloudEventCollector/README.md
Outdated
Show resolved
Hide resolved
Packs/AzureSecurityCenter/Integrations/MicrosoftDefenderForCloudEventCollector/README.md
Outdated
Show resolved
Hide resolved
|
@gal-forer @DeanArbel @yucohen @michal-dagan Doc review completed. |
Docs review. Co-authored-by: ShirleyDenkberg <[email protected]>
Merge branch 'master' of github.com:demisto/content into Microsoft_Defender_For_Cloud_Collector
cweltPA
pushed a commit
that referenced
this pull request
May 29, 2023
* Added the base code * more structural changes * added yml and description * added a test * commit * Adding tests * added tests and documentation * removed a duplicate yml conf * commit * commit * commit * commit * commit * changed events typo * formating the code * changes with nextLink * added support for the pagination * commit * commit * commit * modified some tests * Finished the tests and some fixes found by tests * added some test and removed the first fetch time param * fixed a test and some bugs in the code * fixed extra arg in test_module * commit * fixes * commit * Added modelign rules * added the rule * changes in yml and description * Added documentation to functions * Added documentation to tests * removed a file * changed to type 9 and bumped docker image * Update Packs/AzureSecurityCenter/Integrations/MicrosoftDefenderForCloudEventCollector/MicrosoftDefenderForCloudEventCollector_description.md Co-authored-by: ShirleyDenkberg <[email protected]> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <[email protected]> * fixed a typo in microsoft * changes after doc review * small change in readme.md * fix validations * commit * change in the modeling rules * Added a first_fetch_time handeling * changed the modeling rule of event.outcome_reason * Added the first_fetch time parameter * Empty-Commit * review changes * added some known limitations * changed the hyrarcy of the modeling rules * fixed xif * modeling rules change names * Fixed the modeling rules * updated docker image * removed the RN for the new pack * minor readme changes * Apply suggestions from code review Docs review. Co-authored-by: ShirleyDenkberg <[email protected]> * added RN and bumped version --------- Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
fixes: link to the issue
Description
This is a new XSIAM collector for Microsoft defender for cloud
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have