Fix Pylint errors in P packs (#38069)

* pylint p packs * docker image updates * rn * Bump pack from version ProofpointThreatResponse to 2.0.21. * Bump pack from version PrismaCloudCompute to 1.7.11. * fix error * pylint error * revert some changes * added memory_threshold to PAN-OS - Block IP - Custom Block Rule Test * added memory_threshold to PAN-OS - Block IP - Static Address Group Test * added memory_threshold PAN-OS - Block URL - Custom URL Category Test * added memroty_treshold to all panorama test playbooks --------- Co-authored-by: Content Bot <[email protected]>
demisto · Jan 15, 2025 · 32d15d1 · 32d15d1
1 parent ca14c46
commit 32d15d1
Show file tree

Hide file tree

Showing 36 changed files with 197 additions and 107 deletions.
diff --git a/Packs/PAN-OS/Integrations/Panorama/Panorama.py b/Packs/PAN-OS/Integrations/Panorama/Panorama.py
@@ -2227,11 +2227,16 @@ def panorama_edit_address_group_command(args: dict):
     addresses_param: str
     addresses_path: str
     result: Any
+    addresses = []
     if type_ == 'dynamic':
         if not match:
             raise Exception('To edit a Dynamic Address group, Please provide a match.')
         match_param = add_argument_open(match, 'filter', False)
         match_path = f"{XPATH_OBJECTS}address-group/entry[@name=\'{address_group_name}\']/dynamic/filter"
+    else:
+        match_param = ""
+        match_path = ""
+        demisto.debug(f"{type_=} -> {match_param=} {match_path=}")
 
     if type_ == 'static':
         if (element_to_add and element_to_remove) or (not element_to_add and not element_to_remove):
@@ -2253,6 +2258,10 @@ def panorama_edit_address_group_command(args: dict):
                 )
         addresses_param = add_argument_list(addresses, 'member', False)
         addresses_path = f"{XPATH_OBJECTS}address-group/entry[@name=\'{address_group_name}\']/static"
+    else:
+        addresses_param = ""
+        addresses_path = ""
+        demisto.debug(f"{type_=} -> {addresses_param=} {addresses_path=}")
 
     description = args.get('description')
     tags = argToList(args['tags']) if 'tags' in args else None
@@ -2270,6 +2279,7 @@ def panorama_edit_address_group_command(args: dict):
     if DEVICE_GROUP:
         address_group_output['DeviceGroup'] = DEVICE_GROUP
 
+    result = None
     if type_ == 'dynamic' and match:
         params['xpath'] = match_path
         params['element'] = match_param
@@ -14354,6 +14364,9 @@ def profile_exception_crud_requests(args: dict, action_type: str) -> Any:
             'xpath': xpath,
             'key': API_KEY,
         }
+    else:
+        params = {}
+        demisto.debug(f"{action_type=} -> {params=}")
 
     try:
         raw_response = http_request(URL, 'GET', params=params)

diff --git a/Packs/PAN-OS/ReleaseNotes/2_3_3.md b/Packs/PAN-OS/ReleaseNotes/2_3_3.md
@@ -0,0 +1,4 @@
+#### Integrations
+
+##### Palo Alto Networks PAN-OS
+Code functionality improvements.
diff --git a/Packs/PAN-OS/pack_metadata.json b/Packs/PAN-OS/pack_metadata.json
@@ -2,7 +2,7 @@
     "name": "PAN-OS by Palo Alto Networks",
     "description": "Manage Palo Alto Networks Firewall and Panorama. Use this pack to manage Prisma Access through Panorama. For more information see Panorama documentation.",
     "support": "xsoar",
-    "currentVersion": "2.3.2",
+    "currentVersion": "2.3.3",
     "author": "Cortex XSOAR",
     "url": "https://www.paloaltonetworks.com/cortex",
     "email": "",

diff --git a/Packs/PaloAltoNetworks_SecurityAdvisories/ReleaseNotes/1_0_9.md b/Packs/PaloAltoNetworks_SecurityAdvisories/ReleaseNotes/1_0_9.md
@@ -0,0 +1,5 @@
+#### Scripts
+
+##### CheckPanosVersionAffected
+- Code functionality improvements.
+- Updated the Docker image to: *demisto/python3:3.11.11.1940698*.
diff --git a/...etworks_SecurityAdvisories/Scripts/CheckPanosVersionAffected/CheckPanosVersionAffected.py b/...etworks_SecurityAdvisories/Scripts/CheckPanosVersionAffected/CheckPanosVersionAffected.py
@@ -50,6 +50,12 @@ def return_result_dataclass(result: list[Advisory]):
         summary_list = [vars(x) for x in result]
         title = result[0]._title
         output_prefix = result[0]._output_prefix
+    else:
+        title = ''
+        summary_list = []
+        outputs = []
+        output_prefix = ''
+        demisto.debug(f"The result isn't of type list. {title=} {summary_list=} {outputs=} {output_prefix=}")
 
     readable_output = tableToMarkdown(title, summary_list)
     command_result = CommandResults(

diff --git a/...tworks_SecurityAdvisories/Scripts/CheckPanosVersionAffected/CheckPanosVersionAffected.yml b/...tworks_SecurityAdvisories/Scripts/CheckPanosVersionAffected/CheckPanosVersionAffected.yml
@@ -43,7 +43,7 @@ script: '-'
 subtype: python3
 timeout: '0'
 type: python
-dockerimage: demisto/python3:3.11.10.115186
+dockerimage: demisto/python3:3.11.11.1940698
 fromversion: 5.5.0
 tests:
 - No tests (auto formatted)
diff --git a/Packs/PaloAltoNetworks_SecurityAdvisories/pack_metadata.json b/Packs/PaloAltoNetworks_SecurityAdvisories/pack_metadata.json
@@ -2,7 +2,7 @@
     "name": "Security Advisories by Palo Alto Networks",
     "description": "Search CVE details from the Palo Alto Security Advisories website.",
     "support": "xsoar",
-    "currentVersion": "1.0.8",
+    "currentVersion": "1.0.9",
     "author": "Cortex XSOAR",
     "url": "https://www.paloaltonetworks.com/cortex",
     "email": "",

diff --git a/Packs/PaloAltoNetworks_Threat_Vault/Integrations/ThreatVaultv2/ThreatVaultv2.py b/Packs/PaloAltoNetworks_Threat_Vault/Integrations/ThreatVaultv2/ThreatVaultv2.py
@@ -560,7 +560,8 @@ def file_command(client: Client, args: Dict) -> List[CommandResults]:
     """
     Get the reputation of a sha256 or a md5 representing an antivirus
     """
-
+    readable_output = ""
+    file_info: dict = {}
     hashes = argToList(args.get("file"))
     command_results_list: List[CommandResults] = []
     dbot_reliability = DBotScoreReliability.get_dbot_score_reliability_from_str(
@@ -592,7 +593,7 @@ def file_command(client: Client, args: Dict) -> List[CommandResults]:
                 readable_output = (
                     f"Hash {_hash} antivirus reputation is unknown to Threat Vault."
                 )
-                file_info = None
+                file_info = {}
             else:
                 raise
 
@@ -622,6 +623,9 @@ def file_command(client: Client, args: Dict) -> List[CommandResults]:
                 headers=HEADERS_FILE,
                 removeNull=True,
             )
+        else:
+            file = Common.File(dbot_score=0)
+            demisto.debug("No response. Initialized file variable.")
 
         command_results = CommandResults(
             readable_output=readable_output,
@@ -636,7 +640,8 @@ def file_command(client: Client, args: Dict) -> List[CommandResults]:
 
 
 def cve_command(client: Client, args: Dict) -> List[CommandResults]:
-
+    readable_output = ""
+    _cve = None
     cves = argToList(args.get("cve"))
     command_results_list: List[CommandResults] = []
 

diff --git a/Packs/PaloAltoNetworks_Threat_Vault/Integrations/ThreatVaultv2/ThreatVaultv2.yml b/Packs/PaloAltoNetworks_Threat_Vault/Integrations/ThreatVaultv2/ThreatVaultv2.yml
@@ -1295,7 +1295,7 @@ script:
     - contextPath: ThreatVault.ATP.PCAP.Name
       description: Threatvault ATP PCAP name.
       type: string
-  dockerimage: demisto/crypto:1.0.0.114611
+  dockerimage: demisto/crypto:1.0.0.117163
   isfetch: true
   script: ''
   subtype: python3

diff --git a/Packs/PaloAltoNetworks_Threat_Vault/ReleaseNotes/2_0_17.md b/Packs/PaloAltoNetworks_Threat_Vault/ReleaseNotes/2_0_17.md
@@ -0,0 +1,5 @@
+#### Integrations
+
+##### Palo Alto Networks Threat Vault v2
+- Code functionality improvements.
+- Updated the Docker image to: *demisto/crypto:1.0.0.117163*.
diff --git a/Packs/PaloAltoNetworks_Threat_Vault/pack_metadata.json b/Packs/PaloAltoNetworks_Threat_Vault/pack_metadata.json
@@ -2,7 +2,7 @@
     "name": "Threat Vault by Palo Alto Networks",
     "description": "Use the Palo Alto Networks Threat Vault to research the latest threats (vulnerabilities/exploits, viruses, and spyware) that Palo Alto Networks next-generation firewalls can detect and prevent.",
     "support": "xsoar",
-    "currentVersion": "2.0.16",
+    "currentVersion": "2.0.17",
     "author": "Cortex XSOAR",
     "url": "https://www.paloaltonetworks.com/cortex",
     "email": "",

diff --git a/Packs/Palo_Alto_Networks_Enterprise_DLP/ReleaseNotes/2_0_15.md b/Packs/Palo_Alto_Networks_Enterprise_DLP/ReleaseNotes/2_0_15.md
@@ -0,0 +1,5 @@
+#### Scripts
+
+##### DlpAskFeedback
+- Code functionality improvements.
+- Updated the Docker image to: *demisto/python3:3.11.11.1940698*.
diff --git a/Packs/Palo_Alto_Networks_Enterprise_DLP/Scripts/DlpAskFeedback/DlpAskFeedback.py b/Packs/Palo_Alto_Networks_Enterprise_DLP/Scripts/DlpAskFeedback/DlpAskFeedback.py
@@ -59,8 +59,7 @@ def create_blocks(message: str, entitlement: str, reply: str) -> list:
 def send_slack_message(entitlement, task, user_id, message):
     lifetime = '1 day'
     expiry_date = dateparser.parse('in ' + lifetime, settings={'TIMEZONE': 'UTC'})
-    if expiry_date:
-        expiry = datetime.strftime(expiry_date, DATE_FORMAT)
+    expiry = datetime.strftime(expiry_date, DATE_FORMAT) if expiry_date else None
 
     entitlement_string = f'{entitlement}@{demisto.investigation().get("id")}'
     if task:

diff --git a/Packs/Palo_Alto_Networks_Enterprise_DLP/Scripts/DlpAskFeedback/DlpAskFeedback.yml b/Packs/Palo_Alto_Networks_Enterprise_DLP/Scripts/DlpAskFeedback/DlpAskFeedback.yml
@@ -58,7 +58,7 @@ dependson:
   should:
   - SlackV3|||send-notification
 runonce: false
-dockerimage: demisto/python3:3.11.10.115186
+dockerimage: demisto/python3:3.11.11.1940698
 runas: DBotWeakRole
 fromversion: 5.5.0
 tests:

diff --git a/Packs/Palo_Alto_Networks_Enterprise_DLP/pack_metadata.json b/Packs/Palo_Alto_Networks_Enterprise_DLP/pack_metadata.json
@@ -5,7 +5,7 @@
     "support": "xsoar",
     "author": "Palo Alto Networks Enterprise DLP",
     "url": "https://www.paloaltonetworks.com/enterprise-data-loss-prevention",
-    "currentVersion": "2.0.14",
+    "currentVersion": "2.0.15",
     "categories": [
         "Network Security"
     ],

diff --git a/Packs/PicusAutomation/Integrations/Picus/Picus.py b/Packs/PicusAutomation/Integrations/Picus/Picus.py
@@ -295,6 +295,8 @@ def getThreatResults():
             vector_name = attacker_peer + " - " + victim_peer
             vectors_results = picus_threat_json_result["vectors"]
 
+            threat_result = ""
+            last_time = ""
             for i in range(len(vectors_results)):
                 if vectors_results[i]["name"] == vector_name:
                     variants_results = vectors_results[i]["variants"]