Access token service doctrine #32
Conversation
There was a problem hiding this comment.
Thanks, @padmasreegade, this is off to a good start, but I spotted a few issues that I think will prevent this from working correctly. I haven't looked closely at the tests yet, since I think it's probably worth fixing the underlying problems first and then seeing how the tests respond. Let me know if you have questions about anything or if I can do more to help, and thanks for all the work on this! I think it's getting close to completion.
module/VuFind/src/VuFind/OAuth2/Repository/AbstractTokenRepository.php
Outdated
Show resolved
Hide resolved
Modified entity interface to align with Doctrine ORM. Modified services and tests to keep in sync with the updated interface.
There was a problem hiding this comment.
Thanks, @padmasreegade, this is looking very good. I have just a few very minor suggestions/observations below.
...VuFind/tests/unit-tests/src/VuFindTest/OAuth2/Repository/AbstractTokenRepositoryTestCase.php
Outdated
Show resolved
Hide resolved
...VuFind/tests/unit-tests/src/VuFindTest/OAuth2/Repository/AbstractTokenRepositoryTestCase.php
Outdated
Show resolved
Hide resolved
…n type openid_nonce
There was a problem hiding this comment.
@padmasreegade, all tests are passing in my VM, though I have a few minor suggestions below.
Are you still seeing failures on your end? If so, we should figure out what is different between our environments....
Raising PR to compare. This is not ready for review yet and the code is not fully functional. There are some failing tests that need to be addressed.