LoginToken Doctrine entity class #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Thanks, @padmasreegade, looks great -- just a few things that need to be adjusted (probably because they were copied-and-pasted from the Laminas\Row class, which works slightly differently in a few places).
demiankatz
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Nearly there, @padmasreegade -- just two very minor adjustments still to go!
demiankatz
requested changes
Jun 18, 2024
demiankatz
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Thanks, @padmasreegade! I made one last small edit to remove the old string-based default date since you've now replaced it via the constructor. Merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create Doctrine entity class - LoginToken