Add basic alias test.

demiankatz · Dec 20, 2023 · 6f81f77 · 6f81f77
1 parent 9a471c8
commit 6f81f77
Show file tree

Hide file tree

Showing 4 changed files with 53 additions and 6 deletions.
diff --git a/module/VuFind/tests/fixtures/language/aliases/Domain/en.ini b/module/VuFind/tests/fixtures/language/aliases/Domain/en.ini
@@ -0,0 +1 @@
+bar = Domain Translation
diff --git a/module/VuFind/tests/fixtures/language/aliases/aliases.ini b/module/VuFind/tests/fixtures/language/aliases/aliases.ini
@@ -0,0 +1,2 @@
+foo = bar
+baz = Domain::bar
diff --git a/module/VuFind/tests/fixtures/language/aliases/en.ini b/module/VuFind/tests/fixtures/language/aliases/en.ini
@@ -0,0 +1 @@
+bar = Translation
diff --git a/module/VuFind/tests/unit-tests/src/VuFindTest/I18n/Translator/Loader/ExtendedIniTest.php b/module/VuFind/tests/unit-tests/src/VuFindTest/I18n/Translator/Loader/ExtendedIniTest.php
@@ -50,7 +50,7 @@ class ExtendedIniTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
-    public function testTranslations()
+    public function testTranslations(): void
     {
         $pathStack = [
             realpath($this->getFixtureDir() . 'language/base'),
@@ -74,7 +74,7 @@ public function testTranslations()
      *
      * @return void
      */
-    public function testFallback()
+    public function testFallback(): void
     {
         $pathStack = [
             realpath($this->getFixtureDir() . 'language/base'),
@@ -98,7 +98,7 @@ public function testFallback()
      *
      * @return void
      */
-    public function testFallbackToSelf()
+    public function testFallbackToSelf(): void
     {
         $pathStack = [
             realpath($this->getFixtureDir() . 'language/base'),
@@ -118,7 +118,7 @@ public function testFallbackToSelf()
      *
      * @return void
      */
-    public function testSelfAsParent()
+    public function testSelfAsParent(): void
     {
         $pathStack = [
             realpath($this->getFixtureDir() . 'language/base'),
@@ -139,7 +139,7 @@ public function testSelfAsParent()
      *
      * @return void
      */
-    public function testParentChain()
+    public function testParentChain(): void
     {
         $pathStack = [
             realpath($this->getFixtureDir() . 'language/base'),
@@ -162,12 +162,55 @@ public function testParentChain()
      *
      * @return void
      */
-    public function testMissingPathStack()
+    public function testMissingPathStack(): void
     {
         $this->expectException(\Laminas\I18n\Exception\InvalidArgumentException::class);
         $this->expectExceptionMessage('Ini file \'en.ini\' not found');
 
         $loader = new ExtendedIni();
         $loader->load('en', null);
     }
+
+    /**
+     * Test alias behavior.
+     *
+     * @return void
+     */
+    public function testAliasing(): void
+    {
+        $pathStack = [
+            realpath($this->getFixtureDir() . 'language/aliases'),
+        ];
+        $loader = new ExtendedIni($pathStack, 'en');
+        $result = $loader->load('en', null);
+        $this->assertEquals(
+            [
+                'bar' => 'Translation',
+                'baz' => 'Domain Translation',
+                'foo' => 'Translation',
+            ],
+            (array)$result
+        );
+    }
+
+    /**
+     * Test that alias behavior can be disabled.
+     *
+     * @return void
+     */
+    public function testDisabledAliasing(): void
+    {
+        $pathStack = [
+            realpath($this->getFixtureDir() . 'language/aliases'),
+        ];
+        $loader = new ExtendedIni($pathStack, 'en');
+        $loader->disableAliases();
+        $result = $loader->load('en', null);
+        $this->assertEquals(
+            [
+                'bar' => 'Translation',
+            ],
+            (array)$result
+        );
+    }
 }