-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the call
API (breaking changes)
#2650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
17 tasks
This was
linked to
issues
Feb 6, 2025
bdemann
requested changes
Feb 7, 2025
examples/experimental/test/end_to_end/candid_rpc/cross_canister_calls/test/tests.ts
Show resolved
Hide resolved
examples/experimental/test/end_to_end/candid_rpc/composite_queries/test/tests.ts
Show resolved
Hide resolved
...build/stable/commands/compile/wasm_binary/rust/stable_canister_template/src/ic/notify_raw.rs
Show resolved
Hide resolved
...build/stable/commands/compile/wasm_binary/rust/stable_canister_template/src/ic/notify_raw.rs
Show resolved
Hide resolved
bdemann
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor
Reviewer
Breaking Changes
call
has had a number of fundamental changes made to it.The
raw
property is now aboolean
, and simply toggles encoding of the arguments and decoding of the return value. Ifraw
is true, theargs
property should be aUint8Array
. Omittingargs
or passing inundefined
whenraw
is set to true will automatically Candid encode the empty argument.We have also removed the
notify
function.call
now has aoneway
property that if set totrue
will immediately resolve the promise and returnvoid
.The error thrown from an unsuccessful
call
now has a slightly different message.