Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default params for the arb property tests #2645

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Use default params for the arb property tests #2645

merged 2 commits into from
Feb 4, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Feb 4, 2025 •
edited by lastmjs
Loading

Contributor

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Indicates breaking changes with suffix "(breaking changes)"
    • Sentence cased
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described

Reviewer

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Indicates breaking changes with suffix "(breaking changes)"
    • Sentence cased
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described

Breaking Changes

  • None

@bdemann bdemann changed the title use default params for the arb prob tests Use default params for the arb property tests Feb 4, 2025
@bdemann bdemann force-pushed the prop_test_reproduction branch from 1329741 to 67d534f Compare February 4, 2025 19:11
@bdemann bdemann linked an issue Feb 4, 2025 that may be closed by this pull request
Improve runPropTests by Utilizing defaultPropTestParams #2646
Closed
@bdemann bdemann requested a review from lastmjs February 4, 2025 19:22
@lastmjs lastmjs enabled auto-merge February 4, 2025 22:50
@bdemann bdemann force-pushed the prop_test_reproduction branch from 2d77598 to d3306ca Compare February 4, 2025 22:51
@lastmjs lastmjs merged commit cf56ff0 into main Feb 4, 2025
374 of 386 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve runPropTests by Utilizing defaultPropTestParams
2 participants
@bdemann @lastmjs