Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update esbuild target to es2024, tsconfig targets to ES2024, tsconfig module to ES2022 #2634

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Update esbuild target to es2024, tsconfig targets to ES2024, tsconfig module to ES2022 #2634

merged 5 commits into from
Feb 4, 2025

Conversation

bdemann
Copy link
Member

@bdemann bdemann commented Feb 3, 2025 •
edited by lastmjs
Loading

Contributor

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Indicates breaking changes with suffix "(breaking changes)"
    • Sentence cased
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described
  • Double check that no ts errors are introduced by removing module from the top level.
    • IMPORTANT: test/get_canister_actor.ts (at least) needs the module to be set to something that allows for dynamic imports
  • Double check with Jordan that moving module to ES2022 for those that still need module is okay.
  • Talk to Jordan about keeping internet_identity tsconfig on target ES2021

Reviewer

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Indicates breaking changes with suffix "(breaking changes)"
    • Sentence cased
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described

Breaking Changes

  • None

@bdemann bdemann force-pushed the update_es_version branch 2 times, most recently from 2b49de7 to 3d284bd Compare February 4, 2025 18:16
@bdemann bdemann marked this pull request as ready for review February 4, 2025 18:16
@bdemann bdemann linked an issue Feb 4, 2025 that may be closed by this pull request
Update all JS modules, targets, etc to ES2023 if possible #2484
Closed
@bdemann bdemann changed the title update azle build target Update azle esbuild and tsconfig targets to es2024 Feb 4, 2025
@bdemann bdemann requested a review from lastmjs February 4, 2025 19:22
@lastmjs lastmjs dismissed their stale review February 4, 2025 22:44

Testing auto-merge

@lastmjs lastmjs enabled auto-merge February 4, 2025 22:44
@lastmjs lastmjs merged commit 4dc0f83 into main Feb 4, 2025
373 of 379 checks passed
@lastmjs lastmjs changed the title Update azle esbuild and tsconfig targets to es2024 Update esbuild target to es2024, tsconfig targets to ES2024, tsconfig module to ES2022 Feb 4, 2025
@bdemann bdemann mentioned this pull request Feb 5, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastmjs lastmjs lastmjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all JS modules, targets, etc to ES2023 if possible
2 participants
@bdemann @lastmjs