Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename id to canisterSelf (breaking changes) #2618

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Rename id to canisterSelf (breaking changes) #2618

wants to merge 4 commits into from
+307 −262

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Jan 30, 2025 •
edited
Loading

Contributor

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Indicates breaking changes with suffix "(breaking changes)"
    • Sentence cased
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described

Reviewer

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Indicates breaking changes with suffix "(breaking changes)"
    • Sentence cased
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described
  • I have double-checked that the new API in Azle is beautifully consistent with:

Breaking Changes

id exported directly from azle has been renamed to canisterSelf.

@lastmjs lastmjs linked an issue Jan 30, 2025 that may be closed by this pull request
id -> canisterSelf #2614
Open
@lastmjs lastmjs changed the title Canister self Rename id to canisterSelf (breaking changes) Jan 30, 2025
@lastmjs lastmjs marked this pull request as ready for review January 30, 2025 23:33
@lastmjs lastmjs requested a review from bdemann January 30, 2025 23:33
@lastmjs lastmjs enabled auto-merge January 31, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann Awaiting requested review from bdemann

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

id -> canisterSelf
1 participant
@lastmjs