Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename canisterBalance to canisterCycleBalance (breaking changes) #2612

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Rename canisterBalance to canisterCycleBalance (breaking changes) #2612

merged 2 commits into from
Jan 31, 2025

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Jan 30, 2025 •
edited by bdemann
Loading

Contributor

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Indicates breaking changes with suffix "(breaking changes)"
    • Sentence cased
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described

Reviewer

  • Code has been declaratized
  • All new functions have JSDoc/Rustdoc comments
  • Error handling beautiful (no unwraps or expects etc)
  • Code tested thoroughly
  • PR title:
    • Indicates breaking changes with suffix "(breaking changes)"
    • Sentence cased
  • Related issues have been linked and all tasks have been completed or made into separate issues
  • New documentation enumerated in the release issue
  • All breaking changes
    • Described below in the "Breaking Changes" section
    • Migration path described
  • I have double-checked that the new API in Azle is beautifully consistent with:

Breaking Changes

canisterBalance exported directly from azle has been renamed to canisterCycleBalance.

@lastmjs lastmjs linked an issue Jan 30, 2025 that may be closed by this pull request
canisterBalance -> canisterCycleBalance #2611
Closed
@lastmjs lastmjs changed the title change the canisterBalance API to canisterCycleBalance Rename canisterBalance to canisterCycleBalance Jan 30, 2025
@lastmjs lastmjs changed the title Rename canisterBalance to canisterCycleBalance Rename canisterBalance to canisterCycleBalance (breaking changes) Jan 30, 2025
@lastmjs lastmjs marked this pull request as ready for review January 30, 2025 19:52
@lastmjs lastmjs requested a review from bdemann January 30, 2025 19:52
bdemann
bdemann previously approved these changes Jan 30, 2025
View reviewed changes
@lastmjs lastmjs enabled auto-merge January 31, 2025 01:41
@lastmjs lastmjs requested a review from bdemann January 31, 2025 01:43
@lastmjs lastmjs merged commit d921d9f into main Jan 31, 2025
379 of 380 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemann bdemann bdemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

canisterBalance -> canisterCycleBalance
2 participants
@lastmjs @bdemann