Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative paths for non-lib imports #1117

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

mcclurejt
Copy link
Contributor

Resolved Issues

  • Fixes issues with library resolution when importing Hyperdrive from another foundry project.
  • Seems to speed up LSP (using vscode-solidity-server in nvim)

@coveralls
Copy link
Collaborator

coveralls commented Jul 26, 2024

Pull Request Test Coverage Report for Build 10164131687

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.5%) to 90.732%

Files with Coverage Reduction New Missed Lines %
contracts/src/deployers/ezeth/EzETHHyperdriveDeployerCoordinator.sol 1 52.0%
contracts/src/libraries/LPMath.sol 1 84.44%
contracts/src/deployers/eeth/EETHHyperdriveDeployerCoordinator.sol 1 59.26%
contracts/src/internal/HyperdriveShort.sol 1 93.7%
contracts/src/deployers/lseth/LsETHHyperdriveDeployerCoordinator.sol 1 55.0%
contracts/src/internal/HyperdriveLong.sol 2 92.5%
contracts/src/deployers/morpho-blue/MorphoBlueHyperdriveDeployerCoordinator.sol 2 64.29%
contracts/src/deployers/reth/RETHHyperdriveDeployerCoordinator.sol 2 52.38%
contracts/src/deployers/erc4626/ERC4626HyperdriveDeployerCoordinator.sol 3 65.52%
contracts/src/deployers/aave/AaveHyperdriveDeployerCoordinator.sol 3 70.0%
Totals Coverage Status
Change from base Build 10116078654: -0.5%
Covered Lines: 2242
Relevant Lines: 2471

💛 - Coveralls

Copy link

github-actions bot commented Jul 26, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: 25713ac Previous: 4ca3f48 Deviation Status
addLiquidity: min 33893 gas 33893 gas 0% 🟰
addLiquidity: avg 197438 gas 197443 gas -0.0025%
addLiquidity: max 474728 gas 474728 gas 0% 🟰
checkpoint: min 40316 gas 40316 gas 0% 🟰
checkpoint: avg 144529 gas 144499 gas 0.0208% 🚨
checkpoint: max 256108 gas 256108 gas 0% 🟰
closeLong: min 31384 gas 31384 gas 0% 🟰
closeLong: avg 135896 gas 135945 gas -0.0360%
closeLong: max 2539399 gas 2539399 gas 0% 🟰
closeShort: min 31327 gas 31327 gas 0% 🟰
closeShort: avg 131275 gas 131311 gas -0.0274%
closeShort: max 271272 gas 271250 gas 0.0081% 🚨
initialize: min 31305 gas 31305 gas 0% 🟰
initialize: avg 352492 gas 352308 gas 0.0522% 🚨
initialize: max 418737 gas 418715 gas 0.0053% 🚨
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 174192 gas 174213 gas -0.0121%
openLong: max 333737 gas 333715 gas 0.0066% 🚨
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 174207 gas 174136 gas 0.0408% 🚨
openShort: max 415018 gas 412616 gas 0.5821% 🚨
redeemWithdrawalShares: min 31211 gas 31211 gas 0% 🟰
redeemWithdrawalShares: avg 74985 gas 74990 gas -0.0067%
redeemWithdrawalShares: max 305184 gas 305162 gas 0.0072% 🚨
removeLiquidity: min 31217 gas 31217 gas 0% 🟰
removeLiquidity: avg 214585 gas 214590 gas -0.0023%
removeLiquidity: max 403554 gas 403554 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate this, but I understand why you need to do it

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that you'll probably want to fix the imports in the etherfi integration that was merged yesterday

@mcclurejt mcclurejt force-pushed the mcclurejt/experiment/relative-pathing branch from b294980 to 0f4a98d Compare July 30, 2024 14:00
@mcclurejt mcclurejt enabled auto-merge July 30, 2024 14:23
@mcclurejt mcclurejt added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit 7beec95 Jul 30, 2024
32 checks passed
@mcclurejt mcclurejt deleted the mcclurejt/experiment/relative-pathing branch July 30, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants