Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not save or private-reply info-messages #2571

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Conversation

r10s
Copy link
Member

@r10s r10s commented Jan 31, 2025

see commit messages for details

successor of #2527

closes #2567
closes #2568

r10s added 2 commits January 31, 2025 14:40
this is what android does as well.
one could allow that partly, eg. if an info-messages has a sender,
but that's probably more confusing.
saving info-messages would result in having them displayed out of context,
which is confusing.

one can think over display them differently,
but that seems not worth the effort.

not allowing to save info-messages is also what whatsapp is doing.
@r10s r10s requested review from zeitschlag and Amzd January 31, 2025 13:46
@r10s r10s added the bug label Jan 31, 2025
Copy link
Collaborator

@zeitschlag zeitschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r10s r10s merged commit f541a94 into main Jan 31, 2025
2 checks passed
@r10s r10s deleted the r10s/hide-save-and-reply branch January 31, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"reply" and "reply privately" on info-messages may lead to ghost-chat do not allow to save info-messages
2 participants