-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let user share their most recent Webxdc-apps #2548
Conversation
8792716
to
8317052
Compare
very nice! some high level comment:
but let's sleep over that, so we do not rename twice :) |
and another high-level comment from testing only: the layout seems not to be adaptive when orientation is changed, see the gallery to get the idea. i always get 4 icons, which are then far too large in landscape. it'd probably be better to give the icons a reasonable size, and let the "flowing grid collection layout" (however this is called) decide how many it can display in a row. that's also be better when supporting looking at iphoneSE1 (would probably have only 3 apps per row) vs iphone15Max (can have 5 or even 6 apps per row) vs ipad (even more :) |
the layout considers the orientation now @r10s |
Also: Disable manual swipe. Users have to press the segmented control
- Replace layout - Refactor (and rename) Webxdc-Grid-Cell - Update translations
798982a
to
c3cb14f
Compare
ftr, i force-pushed to get unrelated translations out of the PR. this part is documented badly: as a rule of thumb, it is fine to edit untranslated and english source in PR, but translations should be pulled in separate PR, i will add some lines to make that clearer EDIT: did so: #2557 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm and also things work as expected.
for the "store" wording, well, we can leave it, also the bot was called "xstore" that time. the strings can be adapted in another PR (i will do that)
for the other tap, however, that is a bit mixed between "my apps" and "recent". i suggest to use the same wording in the code, maybe "recently used" or "recent" (so only rename "myApps". but that is no blocker.
Co-authored-by: bjoern <[email protected]>
Brings back "Most recent Webxdc-apps", but this time in the new AppPicker (next to the store). Also includes some refactorings and cleanups: Cells, CollectionView, Layout.
Closes #2530.