Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user share their most recent Webxdc-apps #2548

Merged
merged 14 commits into from
Jan 29, 2025
Merged

Conversation

zeitschlag
Copy link
Collaborator

@zeitschlag zeitschlag commented Jan 23, 2025

Brings back "Most recent Webxdc-apps", but this time in the new AppPicker (next to the store). Also includes some refactorings and cleanups: Cells, CollectionView, Layout.

2530

Closes #2530.

@zeitschlag zeitschlag changed the title 2530 recent apps Let user share their most recent Webxdc-apps Jan 24, 2025
@zeitschlag zeitschlag marked this pull request as ready for review January 24, 2025 15:15
@zeitschlag zeitschlag self-assigned this Jan 24, 2025
@zeitschlag zeitschlag requested a review from r10s January 24, 2025 15:15
@r10s r10s added the enhancement actually in development, user visible enhancement label Jan 24, 2025
@r10s
Copy link
Member

r10s commented Jan 24, 2025

very nice!

some high level comment:

  • we avoid the wording "Store" somehow, not only because of apple :) so, let's call that tab "Browse", and also rename the source code accordingly

  • the other page i would call "Recents" (for translators, "Recently Used" could serve as a maybe better pattern, but that could go to the translator hints)

but let's sleep over that, so we do not rename twice :)

@r10s
Copy link
Member

r10s commented Jan 24, 2025

and another high-level comment from testing only:

the layout seems not to be adaptive when orientation is changed, see the gallery to get the idea. i always get 4 icons, which are then far too large in landscape.

it'd probably be better to give the icons a reasonable size, and let the "flowing grid collection layout" (however this is called) decide how many it can display in a row. that's also be better when supporting looking at iphoneSE1 (would probably have only 3 apps per row) vs iphone15Max (can have 5 or even 6 apps per row) vs ipad (even more :)

@zeitschlag zeitschlag requested review from r10s and removed request for r10s January 27, 2025 09:36
@zeitschlag
Copy link
Collaborator Author

the layout seems not to be adaptive when orientation is changed

the layout considers the orientation now @r10s

@r10s r10s force-pushed the 2530-recent-apps branch from 798982a to c3cb14f Compare January 27, 2025 13:17
@r10s
Copy link
Member

r10s commented Jan 27, 2025

ftr, i force-pushed to get unrelated translations out of the PR. this part is documented badly: as a rule of thumb, it is fine to edit untranslated and english source in PR, but translations should be pulled in separate PR, i will add some lines to make that clearer EDIT: did so: #2557

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm and also things work as expected.

for the "store" wording, well, we can leave it, also the bot was called "xstore" that time. the strings can be adapted in another PR (i will do that)

for the other tap, however, that is a bit mixed between "my apps" and "recent". i suggest to use the same wording in the code, maybe "recently used" or "recent" (so only rename "myApps". but that is no blocker.

Co-authored-by: bjoern <[email protected]>
@zeitschlag zeitschlag merged commit 9f74c20 into main Jan 29, 2025
2 checks passed
@zeitschlag zeitschlag deleted the 2530-recent-apps branch January 29, 2025 12:22
@r10s r10s added the webxdc label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement webxdc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring recent Webxdc-Apps back
2 participants