Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Share invite link"-button to "QR Invite Code"-Screen #2276

Closed
r10s opened this issue Aug 20, 2024 · 0 comments · Fixed by #2294
Closed

Add "Share invite link"-button to "QR Invite Code"-Screen #2276

r10s opened this issue Aug 20, 2024 · 0 comments · Fixed by #2294
Assignees
@zeitschlag
Labels
enhancement actually in development, user visible enhancement
Milestone
1.46.10

Comments

@r10s
Copy link
Member

r10s commented Aug 20, 2024

add "share invite link" beside qr code in "add contact" screen.

either below (as on android) or, probably better, above with an excerpt of the visible invite link, above, as on simplex

compare deltachat/deltachat-android#3176
@r10s r10s added the enhancement actually in development, user visible enhancement label Aug 20, 2024
@zeitschlag zeitschlag changed the title add "share invite link" beside qr code in "add contact" screen Add "Share invite link"-button to "QR Invite Code"-Screen Aug 29, 2024
zeitschlag added a commit that referenced this issue Aug 31, 2024
@zeitschlag
Cleanup and refactorings (#2276)
798b270 
Also: Fix constraints and correctly set height for QR-code-image.
@zeitschlag zeitschlag mentioned this issue Aug 31, 2024
Merged
zeitschlag added a commit that referenced this issue Sep 2, 2024
@zeitschlag
Add link-button (#2276)
ea3dec6
zeitschlag added a commit that referenced this issue Sep 2, 2024
@zeitschlag
Create ViewController only once (#2276)
7846ebe
zeitschlag added a commit that referenced this issue Sep 3, 2024
@zeitschlag
Don't recreate QRViewController all the time (#2276)
c99a9a9 
More of a code smell fix than something that has to do with the invite-link
zeitschlag added a commit that referenced this issue Sep 4, 2024
@zeitschlag
Improve landscape-view for QR-code (#2276)
ee9c55c 
It's scrollable!
zeitschlag added a commit that referenced this issue Sep 4, 2024
@zeitschlag
Localize Button Title (#2276)
5178509
zeitschlag added a commit that referenced this issue Sep 5, 2024
@zeitschlag
Cleanup and refactorings (#2276)
3f18ed4 
Also: Fix constraints and correctly set height for QR-code-image.
zeitschlag added a commit that referenced this issue Sep 5, 2024
@zeitschlag
Add link-button (#2276)
3cfd0e6
zeitschlag added a commit that referenced this issue Sep 5, 2024
@zeitschlag
Create ViewController only once (#2276)
84ac383
zeitschlag added a commit that referenced this issue Sep 5, 2024
@zeitschlag
Don't recreate QRViewController all the time (#2276)
789eb11 
More of a code smell fix than something that has to do with the invite-link
zeitschlag added a commit that referenced this issue Sep 5, 2024
@zeitschlag
Improve landscape-view for QR-code (#2276)
21c746c 
It's scrollable!
zeitschlag added a commit that referenced this issue Sep 5, 2024
@zeitschlag
Localize Button Title (#2276)
06bd3a3
@github-project-automation github-project-automation bot moved this from Todo to Done in onboard friends Sep 5, 2024
@zeitschlag zeitschlag added this to the Next Release milestone Sep 5, 2024
@zeitschlag zeitschlag self-assigned this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeitschlag zeitschlag

Labels
enhancement actually in development, user visible enhancement
Projects
onboard friends
Status: Done
Milestone
1.46.10
Development

Successfully merging a pull request may close this issue.

Add Button to share Link to QR-Code-Screen (#2276) deltachat/deltachat-ios
2 participants
@zeitschlag @r10s