Add stockstrings for reactions in chatlist & update chatlistitem on reaction event #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
added
wait-for-core
this commit could be reverted when rebasing onto the chatlist events pr #3268 (depending on pr merge order)
Simon-Laux
force-pushed
the
simon/i3744-reactions-in-chatlist
branch
from
e64351b to
cd02862
Compare
r10s
approved these changes
Apr 4, 2024
|
note to the person merging this: we can not merge it before we have a new core version with this (because the missing constants will break the build), maybe that new core version will also include the chatlist events (desktop #3268, core chatmail/core#4476) in that case we would drop the event listener commit before merging to resolve the merge conflict.
worked for me, I tested it |
|
yeah, let's do a core release, this is also helpful for ios (i am currently afk, will do one unless it happened until i'm back :) |
adzialocha
changed the title
adzialocha
approved these changes
Apr 9, 2024
Simon-Laux
removed
the
wait-for-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3744
depends on a new core version that includes chatmail/core#5387 and some other small fix prs (that are included in the next version anyway, so I don't need to list them here, just use core
mainbranch)