Refactor message (scss classes edition) #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from it, also remove an unused class in msg list
remove unused stuff remove collapseMetadata
rename text
and remove sth unused
Simon-Laux
requested review from
Jikstra,
nicodh and
evlli
and removed request for
Jikstra
evlli
approved these changes
Nov 9, 2019
Jikstra
approved these changes
Nov 9, 2019
| To avoid collisions you MUST NOT create global styles with generic names that aren't a component. | ||
| Also make sure that global module-classes don't have a class name that is allready used (search all files with `grep` or a similar tool) | ||
|
|
||
| When using generic classnames like `date`, `avatar`, `username`, `error` make sure to scope them in an component scss class. |
There was a problem hiding this comment.
Nice that you document it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning with renaming and duplicating css.
and reorganizing it.
best reviewed on a commit by commit basis.