1.48.0 crashes sometimes when i try to quote-reply

[hpk42]

[WofWca]

Is it 100% reproducible for you? I can't reproduce.

[hpk42]

No, it's not reproducible. If that rules out fixing it feel free to close. I'll file another issue if it reappears. Was the first itme i encountered it (but i am also not often quote-replying to webxdc-app messages).

…

On Wed, Nov 13, 2024 at 02:09 -0800, WofWca wrote: Is it 100% reproducible for you? I can't reproduce. -- Reply to this email directly or view it on GitHub: #4337 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>

[WofWca]

I looked through all the .slice we have in the codebase and narrowed it down to these two lines:

deltachat-desktop/packages/frontend/src/components/message/Message.tsx

Line 805 in 78fef8b

quote.text.slice(0, 3000 /* limit quoted message size */) || ''

deltachat-desktop/packages/frontend/src/components/Reactions/index.tsx

Line 35 in a5c0243

.slice(0, SHOW_MAX_DIFFERENT_EMOJIS)

They produce the same stack trace as in the screenshot you posted, unlike other .slice. I might have missed some, but the first line I mentioned looks like the likely candidate. Edit: or IDK, I do not see how quote can have an undefined text: it's provided by the core, and it should always be a string.

[WofWca]

@Simon-Laux also encountered this issue:

must be in react render function and inside of the message list+composer component, because that error boundary was triggered. I also can not reproduce it with the echo bot. basically I was quickly switching between quote messages while your answers came in.

And I myself also just managed to reproduce this with [email protected]. I sent a message to it and starting quickly pressing Ctrl+Up to quote, and got the crash: Cannot read properties of undefined (reading 'slice').

And indeed it points to this line, Message.tsx:805:28):

deltachat-desktop/packages/frontend/src/components/message/Message.tsx

Line 805 in 78fef8b

quote.text.slice(0, 3000 /* limit quoted message size */) || ''

However, I am not 100% sure that this is the very same issue as in the original post.

[WofWca]

This is what I got by putting a conditional breakpoint quote.text == undefined there.

Looks like these two pieces of code could be causing the crash:

deltachat-desktop/packages/frontend/src/components/composer/Composer.tsx

Lines 599 to 602 in f9362a9

	draftRef.current.quote = {
	kind: 'WithMessage',
	messageId,
	} as Type.MessageQuote

deltachat-desktop/packages/frontend/src/components/composer/Composer.tsx

Lines 662 to 665 in f9362a9

	draftRef.current.quote = {
	kind: 'WithMessage',
	messageId,
	} as Partial<Type.MessageQuote> as any as Type.MessageQuote

They actually mutate the state, draftState, bypassing _setDraft, and make the state invalid (because .quote is missing the required properties). draftRef was introduced in 4bbdbe3.

I think this issue should belong to the "New Composer" project, given that it is not super severe. Un-assign it from the project if you disagree.