account list events and private tags #4280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
added
bug
…d`) instead of using the `window.__updateAccountListSidebar` workaround where possible.
Simon-Laux
force-pushed
the
simon/account-list-events-and-private-tags
branch
from
6fae38d
to
17e032c
Compare
nicodh
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Tested with local core on deltachat/deltachat-core-rust#6118
|
depends on #4364 |
|
Needs core v1.151.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccountsChangedandAccountsItemChanged) instead of using thewindow.__updateAccountListSidebarworkaround where possible.moves ui update responsibility for account list to core and adds private profile tag feature.
closes #4249
closes #4250
depends on
AccountsChangedandAccountsItemChangedevents deltachat-core-rust#6118 mergedTodo/review: test all cases described in deltachat/deltachat-core-rust#6106