Account list update events

[Simon-Laux]

What?

Emit events from core when Account List items change, similar to how chatlist UI events (#4476) were added.

How?

• AccountListChanged
  • account id = 0 -> already used to emit accounts from the account manager (todo reference?)
  • This event is needed for addition and deletion of accounts. (technically it is for completeness)
• AccountListItemChanged
  • account id = <id of account>

Update Cases for AccountListItemChanged:

Basically when properties in the jsonrpc Account Object changes, so

• configuration
• profile image change (config('selfavatar'))
• selfname change (config('displayname') and config('addr'))
• config("private_tag") - not yet in account object, but should be added there soon (feat: jsonrpc: add private_tag to Account::Configured Object #6107)
• backup import
• after receiving backup (setup second device flow)

Why?

• desktop currently uses a global workaround window.__updateAccountListSidebar function pointer to update the account list sidebar ui when it changes, we want to remove that less than ideal workaround.
• After loading a backup, the avatar is only displayed after the profile is selected again. deltachat-desktop#4250 is a direct issue that would be solved by this
• this is similar to how desktop handled chat list updates before api: add ChatListChanged and ChatListItemChanged events #4476

Basically move the responsibility for notifying the ui of updates to the core, to reduce need for workarounds in UI.
Yes in this case mostly desktop will benefit, but when android and iOS add proper tablet support/UI then they will benefit too.
deltatouch also has a desktop/tablet ui mode where the account list is always shown.

Who will do it?

I'm willing to do this. The intention in making this issue instead of a private note is to get feedback early.

Why now?

• After loading a backup, the avatar is only displayed after the profile is selected again. deltachat-desktop#4250
• it is a backlog item of Account Sidebar: Further Steps deltachat-desktop#3671

[iequidoo]

• Do we need "account id" inside an event? AFAIU you subscribe to events of a particular account.
• I'd suggest to think about more consistent naming, there is no such thing as AccountList in the core, only struct Accounts. So, i think AccountsChanged and AccountsItemChanged may be better.

[Simon-Laux]

Do we need "account id" inside an event?

The event emitter that desktop uses is on the Account Manager, all events have an id field for the account id, afaik events that are emitted in the account manager have id=0.
So no we don't need it inside EventType, because it is already "outside" in the Event.

So, i think AccountsChanged and AccountsItemChanged may be better.

fair point, though when we add sorting you might say the order that could change makes it a list? anyways I don't really care much about specific naming in this case, so would just agree here, unless there are other better suggestions.