WIP: refactor: add failing test: arhive updated event #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the test fail (and rightly so). This is the cause of https://github.com/deltachat/deltachat-desktop/issues/4016
WofWca
commented
Jul 10, 2024
Comment on lines
5889
to
5894
| // mark one of the archived+muted chats as noticed: check that the archive-link counter is changed as well | ||
| marknoticed_chat(&t, claire_chat_id).await?; | ||
| assert_eq!(bob_chat_id.get_fresh_msg_cnt(&t).await?, 2); | ||
| assert_eq!(claire_chat_id.get_fresh_msg_cnt(&t).await?, 0); | ||
| wait_for_chatlist_and_specific_item(&t, DC_CHAT_ID_ARCHIVED_LINK).await; | ||
| assert_eq!(DC_CHAT_ID_ARCHIVED_LINK.get_fresh_msg_cnt(&t).await?, 1); |
There was a problem hiding this comment.
This is the place where it fails
|
Superseded by #5771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stub MR to highlight the issue.
This makes the test fail (and rightly so).
This is the cause of #5768
TBH I have no idea how to fix it, where to add
emit_msgs_changed(DC_CHAT_ID_ARCHIVED_LINKwhen a chat is noticed, there doesn't seem to be one universal place for it, it's all mostly SQL.But if someone has an idea, I could try to finish this, or just share my findings.
Also perhaps you would disagree with changing the test this way because these kids of tests are mostly put in
chatlist_event.rs. But IDK seems a little weird to me to split them like this.For reference, here is the history of related changes:
ChatListChangedandChatListItemChangedevents #4476 - this doesn't affect archive events too much, apparently, it only adds extraChatlistItemChangedandChatlistChangedevents on top ofMsgsChanged