Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare 1.50.0 #3462

Merged
merged 2 commits into from
Dec 3, 2024
Merged

prepare 1.50.0 #3462

merged 2 commits into from
Dec 3, 2024

Conversation

adbenitez
Copy link
Member

No description provided.

@adbenitez adbenitez requested review from r10s and Hocuri December 3, 2024 10:37
@adbenitez adbenitez self-assigned this Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@@ -1181,7 +1181,7 @@
<string name="perm_enable_bg_already_done">You already allowed Delta Chat to receive messages in the background.\n\nIf messages still do not arrive in background, please also check your system settings.</string>

<!-- device messages for updates -->
<string name="update_1_46_android">New Onboarding 🐣 and More:\n\n⚡️ Sign up to secure fast chatmail servers (https://delta.chat/chatmail) or use classic e-mail servers\n\n👉 PUSH notifications for any chatmail server\n\n👤 Connect your friends securely via \"Attach contacts\"\n\n🥰 React with any emoji\n\n📌 Pin chats directly from search … and MORE at %1$s</string>
<string name="update_1_50_android">New Emoji Picker ❤️‍🔥 and More:\n\n🆕 New emoji picker with support for more emojis\n\n🎮 Webxdc apps can now trigger notifications and deep-link to sections directly on opening by tapping in-chat announcements\n\n👍 Notify reactions to your messages\n\n🔔 Change to more natural order of messages in grouped notifications\n\n🥸 Don\'t expose your real email address to Webxdc apps … and MORE at %1$s</string>
Copy link
Member

@r10s r10s Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not saying "webxdc" in a user-facing way, in general, the device message could be less technical, and more written for the normie, i.e.:

Suggested change
<string name="update_1_50_android">New Emoji Picker ❤️‍🔥 and More:\n\n🆕 New emoji picker with support for more emojis\n\n🎮 Webxdc apps can now trigger notifications and deep-link to sections directly on opening by tapping in-chat announcements\n\n👍 Notify reactions to your messages\n\n🔔 Change to more natural order of messages in grouped notifications\n\n🥸 Don\'t expose your real email address to Webxdc apps … and MORE at %1$s</string>
<string name="update_1_50_android">What's new?\n\n❤️‍🔥 New emojis picker with more emoji\n\n🎮 Enhanced in-chat apps: Get notifications and open supporting apps in context\n\n📆 i.e. open an added calendar entry directly\n\n👍 Get notified about reactions to your messages\n\n... FIXES and EVEN MORE at %1$s</string>

i also stroke the last two point, i think they're minor and hard to explain the normal will probably have more questions when reading that.

feel free to pick only some things or nothing :)

Copy link
Member Author

@adbenitez adbenitez Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"open supporting apps in context" even I am having a hard time to understand this 😅 and the explanation about calendar in a separated entry/topic I would put it together in the same item, it is a bit weird like that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the explanation about calendar in a separated entry/topic I would put it together in the same item

+1

Copy link
Member

@r10s r10s Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"open supporting apps in context" even I am having a hard time to understand this 😅

agree, it was only the first that came into my mind. i am not super-happy with that as well. the "i.e." is only a poor method for clarification ...

how can we say that easier?

@adbenitez adbenitez merged commit b735759 into main Dec 3, 2024
1 of 2 checks passed
@adbenitez adbenitez deleted the prep-1.50.0 branch December 3, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants