don't say 'Done' when we do not know we're done #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding a shortcut is sometimes a request only, the user has to confirm and/or there is a subsequent dialog. so, when `requestPinShortcut()` returns successfully, saying "Done" as the result of "Add to Home Screen" is often wrong from the view of the user. however, some feedback is still needed for the cases there are no dialogs. saying "One moment..." covers both cases sufficiently.
r10s
force-pushed
the
r10s/tweak-shortcut-feedback
branch
from
22f97e4 to
7af087a
Compare
adbenitez
approved these changes
Apr 27, 2024
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a webxdc-shortcut to the home screen is sometimes a request only,
the user has to confirm and/or there is a subsequent dialog.
so, when
requestPinShortcut()returns successfully, saying "Done" as the result of "Add to Home Screen" is often wrong from the view of the user.however, some feedback is still needed for the cases there are no dialogs.
saying "One moment..." covers both cases sufficiently.
this is a bit misleading
(came over that when playing with webxdc during review of #3008 )