allow to backup/export all accounts at once #2735
Conversation
adbenitez
added
the
enhancement
|
To test the changes in this pull request, install this apk: |
|
A lot of phones do not even have enough space for a backup of a single account. If we go this way on Android, there should be an option to select some subset of accounts in the dialog with checkboxes, and a checkbox for "all accounts" on top of this that enables all or disables all of them. |
|
that would get too complicated too soon, if the device doesn't have enough space then backup one by one instead of using all, anyway selecting only a subset also needs to know account size to make an informed decision and then that is more features |
|
To test the changes in this pull request, install this apk: |
|
for exporting all accounts it gets a bit complicated, because there is no blocking way to call "create backup" per account, the core API for backups is async and you can't just loop over an array of accounts and call the "create backup" API, progress is received via core event and you would need to start the backup of the next account in the "progress 1000" of the previous one, etc. would be nice to have an API that blocks until the backup is done or an API to "backup all" accounts similar to the startIO for all accounts, that would be even better/easier for the UI cc @link2xt |
|
To test the changes in this pull request, install this apk: |
this starts all backups at the same time, overwriting different progress-dialogs as needed. when the last "done" arrives, the progress dialog is closed. the progress itself, is taken from the first account (this could be improved, but maybe it is just good enough)
start all backups
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
⚠️ before this gets merged, would be nicer if core sets the account address in the backup filename