-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove code coverage workflow #628
Merged
moritzkirstein
merged 1 commit into
development
from
chore/remove-code-coverage-workflow
Jan 15, 2025
Merged
chore: remove code coverage workflow #628
moritzkirstein
merged 1 commit into
development
from
chore/remove-code-coverage-workflow
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
85c72cd
to
2918955
Compare
@KevinRohlf it looks like this branch needs alignment with |
efa913d
to
df5babd
Compare
moritzkirstein
approved these changes
Jan 15, 2025
moritzkirstein
pushed a commit
that referenced
this pull request
Jan 20, 2025
moritzkirstein
pushed a commit
that referenced
this pull request
Jan 30, 2025
moritzkirstein
pushed a commit
that referenced
this pull request
Jan 30, 2025
* feat: check credential ID match warning (#634) * feat: add warning state & compare credential id with gx:dependsOn to filter out the correct ID * chore: rename matchverifiable to isIdMatchVerifiable, update Badge and verifyRawServiceCredential function * fix: update isIdMatchVerifiable type to string and adjust related logic in Badge and verifyRawServiceCredential * refactor: remove console.log * refactor: correct casing in setIsIdMatchVerifiable * refactor: simplify return structure in verifyRawServiceCredential to use a constant for verified & complianceApiVersion and update dependsOnIds * fix: update isWarning condition to check length of isIdMatchVerifiable in Badge component * fix: update condition to check for empty rootService array in verifyRawServiceCredential * refactor: store credentialSubject in a constant for improved readability in verifyRawServiceCredential * fix: update idMatch condition to check for both original and lowercase DID in verifyRawServiceCredential * chore: remove code coverage workflow (#628) * feat: add automation switch and conditional rendering * feat: enable conditional rendering for automation context based on app config
moritzkirstein
pushed a commit
that referenced
this pull request
Feb 3, 2025
* feat: check credential ID match warning (#634) * feat: add warning state & compare credential id with gx:dependsOn to filter out the correct ID * chore: rename matchverifiable to isIdMatchVerifiable, update Badge and verifyRawServiceCredential function * fix: update isIdMatchVerifiable type to string and adjust related logic in Badge and verifyRawServiceCredential * refactor: remove console.log * refactor: correct casing in setIsIdMatchVerifiable * refactor: simplify return structure in verifyRawServiceCredential to use a constant for verified & complianceApiVersion and update dependsOnIds * fix: update isWarning condition to check length of isIdMatchVerifiable in Badge component * fix: update condition to check for empty rootService array in verifyRawServiceCredential * refactor: store credentialSubject in a constant for improved readability in verifyRawServiceCredential * fix: update idMatch condition to check for both original and lowercase DID in verifyRawServiceCredential * chore: remove code coverage workflow (#628) * feat: add automation switch and conditional rendering * feat: enable conditional rendering for automation context based on app config
moritzkirstein
pushed a commit
that referenced
this pull request
Feb 6, 2025
* feat: check credential ID match warning (#634) * feat: add warning state & compare credential id with gx:dependsOn to filter out the correct ID * chore: rename matchverifiable to isIdMatchVerifiable, update Badge and verifyRawServiceCredential function * fix: update isIdMatchVerifiable type to string and adjust related logic in Badge and verifyRawServiceCredential * refactor: remove console.log * refactor: correct casing in setIsIdMatchVerifiable * refactor: simplify return structure in verifyRawServiceCredential to use a constant for verified & complianceApiVersion and update dependsOnIds * fix: update isWarning condition to check length of isIdMatchVerifiable in Badge component * fix: update condition to check for empty rootService array in verifyRawServiceCredential * refactor: store credentialSubject in a constant for improved readability in verifyRawServiceCredential * fix: update idMatch condition to check for both original and lowercase DID in verifyRawServiceCredential * chore: remove code coverage workflow (#628) * feat: add automation switch and conditional rendering * feat: enable conditional rendering for automation context based on app config
moritzkirstein
pushed a commit
that referenced
this pull request
Feb 13, 2025
* feat: check credential ID match warning (#634) * feat: add warning state & compare credential id with gx:dependsOn to filter out the correct ID * chore: rename matchverifiable to isIdMatchVerifiable, update Badge and verifyRawServiceCredential function * fix: update isIdMatchVerifiable type to string and adjust related logic in Badge and verifyRawServiceCredential * refactor: remove console.log * refactor: correct casing in setIsIdMatchVerifiable * refactor: simplify return structure in verifyRawServiceCredential to use a constant for verified & complianceApiVersion and update dependsOnIds * fix: update isWarning condition to check length of isIdMatchVerifiable in Badge component * fix: update condition to check for empty rootService array in verifyRawServiceCredential * refactor: store credentialSubject in a constant for improved readability in verifyRawServiceCredential * fix: update idMatch condition to check for both original and lowercase DID in verifyRawServiceCredential * chore: remove code coverage workflow (#628) * feat: add automation switch and conditional rendering * feat: enable conditional rendering for automation context based on app config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes