Feat/DDO to Gaia-X Service Credential #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e download DDO button visible outside debug mode
…edentials, and improved modal styling
KevinRohlf
requested review from
moritzkirstein,
oceanByte and
Abrom8
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
oceanByte
requested changes
Oct 11, 2024
… CSS,merged functions, adjusted validation, added button type, updated output JSON, and modified text fields
oceanByte
approved these changes
Oct 15, 2024
Merged
oceanByte
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Feat/ddo export (#593) * feat: add download DDO button * feat: added comments * refactor: extract downloadJSON function, add JSON validation, and make download DDO button visible outside debug mode * refactor: update JSON validation * Feat/DDO to Gaia-X Service Credential (#595) * feat: add download DDO button * feat: added comments * refactor: extract downloadJSON function, add JSON validation, and make download DDO button visible outside debug mode * feat: created new JSON and added modal for data input * feat: updated JSON, changed modal title, added delete function for credentials, and improved modal styling * fix: resolved issue with button type attribute * fix: fixed createServiceCredential function * fix: format correctly * feat: migrated form to Formik * feat: added validation and placeholder * refactor: updated typing,removed console.log, fix tooltip, cleaned up CSS,merged functions, adjusted validation, added button type, updated output JSON, and modified text fields * refactor: replaced values with placeholders for gx:URL and gx:hash in JSON * feat: resolved address to display name (#598) * feat: resolved address to display name * chore: added comments for begin and end * chore: update comment --------- Co-authored-by: Moritz Kirstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes