Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: service credentials id check #391

Merged
merged 5 commits into from
Jul 20, 2023
Merged

feat: service credentials id check #391

merged 5 commits into from
Jul 20, 2023

Conversation

LucaMilanese90
Copy link
Contributor

@LucaMilanese90 LucaMilanese90 commented Jul 19, 2023 •
edited
Loading

Proposed Changes

  • verify if the service credential ID match with the associated asset's DID
  • rename service self-description into service credential

@vercel
Copy link

vercel bot commented Jul 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mvg-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 0:11am

@LucaMilanese90 LucaMilanese90 force-pushed the feat/service-credentials-additional-check branch from cfc749f to c2ac173 Compare July 19, 2023 15:07
@LucaMilanese90
Copy link
Contributor Author

Example with valid credential and matching id: https://mvg-portal-git-feat-service-credentials-additio-e1f5bc-deltadao.vercel.app/asset/did:op:2e148b5c1ff12590c13bc018100743f0253f22f49cbaf7876612b2417f961789
Example with valid credential and non-matching id: https://mvg-portal-git-feat-service-credentials-additio-e1f5bc-deltadao.vercel.app/asset/did:op:bb0e9a01fda53c71e328eb7ccc91215c63a0964e9d3435875553e4754238b15e

@moritzkirstein moritzkirstein merged commit 705fef7 into main Jul 20, 2023
@moritzkirstein moritzkirstein deleted the feat/service-credentials-additional-check branch July 20, 2023 12:24
This was referenced Aug 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaimeinke kaimeinke kaimeinke left review comments

@moritzkirstein moritzkirstein moritzkirstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucaMilanese90 @moritzkirstein @kaimeinke