Skip to content

Commit

Permalink
Merge bitcoin/bitcoin#25990: test: apply fixed feerate to avoid varia…
Browse files Browse the repository at this point in the history
…ble dynamic fees in wallet_groups.py

2186608 test: apply fixed feerate to avoid variable dynamic fees (stickies-v)

Pull request description:

  Without specifying a feerate, we let the wallet decide on an appropriate feerate, which can be influenced by various factors
  such as what's in the mempool. Since wallet_groups.py fails when feerates are unstable, we should use a fixed feerate across all nodes. The assumed feerate was 20 sats/vbyte, so this PR adopts that.

  Closes #25940. I'm not 100% sure, but I think the increased tx relay speed introduced by #25865 caused the transactions to more quickly and often enter the other nodes' mempools, affecting their feerate calculation done in [`wallet:GetMinimumFeeRate()`](https://github.com/bitcoin/bitcoin/blob/ea67232cdb80c4bc3f16fcd823f6f811fd8903e1/src/wallet/fees.cpp#L68-L72) and thus deviating slightly from the expected 20 sats/vbyte.

  Ran `wallet_groups.py` over 400 times without failure.

ACKs for top commit:
  aureleoules:
    ACK 2186608.
  glozow:
    Approach ACK 2186608

Tree-SHA512: 0ea467a67747e6f27369ccd0adacfb21cc36ef0ae728fb28b8ea18e409aab5bd3ede559d6cebb82da0b9703c0c8b2709d686feb3ae009ddf525aa253f44d5816
  • Loading branch information
MacroFake committed Sep 9, 2022
2 parents 013924a + 2186608 commit dd3ada6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/functional/wallet_groups.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ def set_test_params(self):
["-maxapsfee=0.00002719"],
["-maxapsfee=0.00002720"],
]
# whitelist peers to speed up tx relay / mempool sync

for args in self.extra_args:
args.append("[email protected]")
args.append("[email protected]") # whitelist peers to speed up tx relay / mempool sync
args.append(f"-paytxfee={20 * 1e3 / 1e8}") # apply feerate of 20 sats/vB across all nodes

self.rpc_timeout = 480

Expand Down

0 comments on commit dd3ada6

Please sign in to comment.