Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK] Refactor IdentityColumnTestUtils #3568

Conversation

zhipengmao-db
Copy link
Contributor

@zhipengmao-db zhipengmao-db commented Aug 16, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

This PR is part of #1959 .
The change refactors IdentityColumnTestUtils to reuse createTableWithIdColAndIntValueCol to create tables and to unify the column names in identity column tests.

How was this patch tested?

This is test only change.

Does this PR introduce any user-facing changes?

No.

Copy link
Contributor

@c27kwan c27kwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@allisonport-db allisonport-db merged commit 95aff65 into delta-io:master Aug 19, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants