-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing null counts for struct type columns in the struct stats #714
Merged
roeap
merged 7 commits into
delta-io:main
from
Tom-Newton:tomnewton/parse_struct_null_counts_for_struct_types
Aug 8, 2022
Merged
Fix parsing null counts for struct type columns in the struct stats #714
roeap
merged 7 commits into
delta-io:main
from
Tom-Newton:tomnewton/parse_struct_null_counts_for_struct_types
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Newton
changed the title
Parse null counts for struct types in struct stats
Fix parsing null counts for struct types in struct stats
Jul 26, 2022
Tom-Newton
changed the title
Fix parsing null counts for struct types in struct stats
Fix parsing null counts for struct type columns in the struct stats
Jul 26, 2022
fvaleye
reviewed
Jul 28, 2022
Unfortunately the PyArrow 4.0.0 build is failing
https://github.com/delta-io/delta-rs/runs/7705681944?check_suite_focus=true |
@Tom-Newton it's not related to your change, but caused by the new arrow 9 release, see #724 (comment). You can ignore it for now and we can handle the fix in a different PR. |
houqp
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reading the struct column stats (as opposed to json column stats) the null counts where ignored for struct type columns. Completely ignoring is probably less bad than parsing them wrongly but if the user was filtering on a struct column this may have impacted performance. It was also spamming error logs:
I probably should have done this as part of #656. Sorry for introducing this slight regression. I think some logging was getting suppressed during the unittest so I didn't notice it was an issue.
Related Issue(s)
Relates to #653 but that was for the most part already solved by #656
Changes