fix: refresh snapshot after vacuuming logs #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
fvaleye,
roeap,
rtyler and
hntd187
as code owners
github-actions
bot
added
binding/python
ion-elgreco
force-pushed
the
fix/refresh-snapshot
branch
from
62f9604 to
ad70cce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3252 +/- ##
==========================================
- Coverage 72.18% 72.08% -0.10%
==========================================
Files 143 143
Lines 45629 45699 +70
Branches 45629 45699 +70
==========================================
+ Hits 32936 32944 +8
- Misses 10621 10682 +61
- Partials 2072 2073 +1 ☔ View full report in Codecov by Sentry. |
ion-elgreco
force-pushed
the
fix/refresh-snapshot
branch
from
ad70cce to
7d4a297
Compare
rtyler
reviewed
Feb 25, 2025
Comment on lines
+1638
to
+1653
| fn write( | ||
| &mut self, | ||
| py: Python, | ||
| data: PyArrowType<ArrowArrayStreamReader>, | ||
| mode: String, | ||
| schema_mode: Option<String>, | ||
| partition_by: Option<Vec<String>>, | ||
| predicate: Option<String>, | ||
| target_file_size: Option<usize>, | ||
| name: Option<String>, | ||
| description: Option<String>, | ||
| configuration: Option<HashMap<String, Option<String>>>, | ||
| writer_properties: Option<PyWriterProperties>, | ||
| commit_properties: Option<PyCommitProperties>, | ||
| post_commithook_properties: Option<PyPostCommitHookProperties>, | ||
| ) -> PyResult<()> { |
There was a problem hiding this comment.
This function body looks really close to the write_to_deltalake function, can the code in write_to_deltalake simply defer to this function now?
There was a problem hiding this comment.
Maybe, I'll investigate!
ion-elgreco
force-pushed
the
fix/refresh-snapshot
branch
from
7d4a297 to
ea025df
Compare
ion-elgreco
force-pushed
the
fix/refresh-snapshot
branch
from
ea025df to
2e2c022
Compare
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
fix/refresh-snapshot
branch
from
2e2c022 to
c2dd8e4
Compare
roeap
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per @roeap suggestion to simply reload the table state after cleaning up logs so that we get a proper snapshot.
Introduces a write function on the DeltaTable which allows us to update the state after writing, which we couldn't do properly before.
Related Issue(s)
cleanup_expired_logs_for#3057