feat: override dynamodb config #3010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-chauvet
requested review from
MrPowers,
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
thomas-chauvet
changed the title
Signed-off-by: Thomas <[email protected]>
Signed-off-by: Thomas <[email protected]>
Signed-off-by: Thomas <[email protected]>
Signed-off-by: Thomas <[email protected]>
Signed-off-by: Thomas <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Thomas <[email protected]>
The release of pyo3 0.22.3 compells this since we cannot otherwise compile. The choice is between pinning 0.22.2 and upgrading our ABI, and I think it's better to upgrade the ABI Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Thomas <[email protected]>
see delta-io/delta-kernel-rs#301 Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Thomas <[email protected]>
Signed-off-by: Thomas <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Thomas <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Thomas <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Thomas <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Thomas <[email protected]>
Signed-off-by: Thomas <[email protected]>
Signed-off-by: Thomas <[email protected]>
Signed-off-by: Thomas <[email protected]>
Signed-off-by: Stephen Carman <[email protected]> Signed-off-by: Thomas <[email protected]>
Today the make_array function from Datafusion uses "item" as the list element's field name. With recent changes in delta-kernel-rs we have switched to calling it "element" which is more conventional related to how Apache Parquet handles things This change introduces a test which helps isolate the behavior seen in Python tests within the core crate for easier regression testing Signed-off-by: R. Tyler Croy <[email protected]> Signed-off-by: Thomas <[email protected]>
Signed-off-by: Vikas Sharma <[email protected]> Signed-off-by: Thomas <[email protected]>
Signed-off-by: Vikas Sharma <[email protected]> Signed-off-by: Thomas <[email protected]>
Signed-off-by: Marko Grujic <[email protected]> Signed-off-by: Thomas <[email protected]>
thomas-chauvet
force-pushed
the
feat/override-dynamodb-config
branch
from
1f37aba
to
b1e889e
Compare
|
Issue with DCO, I'll re-open a PR ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the possibility to override dynamoDB configuration via
storage_options:AWS_ENDPOINT_URL_DYNAMODBoverridesAWS_ENDPOINT_URL,AWS_REGION_DYNAMODBoverridesAWS_REGION,AWS_ACCESS_KEY_ID_DYNAMODBoverridesAWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY_DYNAMODBoverridesAWS_SECRET_ACCESS_KEY.It solves cases where we use an S3-compatible storage without mutual exclusion but we want to use DynamoDB anyway as a locking provider.
It also solves the case where we want to pass different credentials or region for S3 and dynamoDB.
Related Issue(s)
Documentation
Documentation has been updated to explain how to override configuration.