Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test coverage command to Makefile #2688

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

fpgmaas
Copy link
Contributor

@fpgmaas fpgmaas commented Jul 20, 2024

Description

This PR proposes to add a make test-cov command to the Makefile to make it easier for contributors to check test coverage.

Output currently looks as follows:

[...]
tests/test_writerproperties.py::test_write_with_writerproperties PASSED    

---------- coverage: platform darwin, python 3.11.2-final-0 ----------
Name                        Stmts   Miss Branch BrPart  Cover
-------------------------------------------------------------
deltalake/__init__.py          11      0      0      0   100%
deltalake/_util.py             16      1     12      1    93%
deltalake/data_catalog.py       6      0      0      0   100%
deltalake/exceptions.py         5      0      0      0   100%
deltalake/fs.py                44     11      2      0    76%
deltalake/schema.py            60      0     22      0   100%
deltalake/table.py            431     42    174     23    89%
deltalake/writer.py           267     98    175     14    58%
-------------------------------------------------------------
TOTAL                         840    152    385     38    78%
Coverage HTML written to dir htmlcov

Also removed --cov=deltalake from the pytest ini commands, because I think that is better moved to [tool.coverage.run].

Related Issue(s)

Documentation

@github-actions github-actions bot added the binding/python Issues for the Python package label Jul 20, 2024
@ion-elgreco
Copy link
Collaborator

Thanks! @fpgmaas

@ion-elgreco ion-elgreco merged commit f9f47db into delta-io:main Jul 20, 2024
21 checks passed
@fpgmaas fpgmaas deleted the chore/test-cov branch July 20, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants