fix: do not write empty parquet file/add on writer close; accurately … #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…track unflushed row group size
alexwilcoxson-rel
requested review from
wjones127,
roeap and
rtyler
as code owners
roeap
approved these changes
Jan 27, 2024
RobinLin666
pushed a commit
to RobinLin666/delta-rs
that referenced
this pull request
Feb 2, 2024
delta-io#2123) …track unflushed row group size # Description When writing a batch with the writer, if that batch would result in a flush and no more batches follow, then on close an empty parquet file (no rows) is written. This includes an Add in the log that looks like ``` Add { path: "part-00002-3da49db6-e5e9-4426-8839-0092a56cc155-c000.parquet", partition_values: {}, size: 346, modification_time: 1706297596165, data_change: true, stats: Some( "{\"numRecords\":0,\"minValues\":{},\"maxValues\":{},\"nullCount\":{}}", ), tags: None, deletion_vector: None, base_row_id: None, default_row_commit_version: None, clustering_provider: None, stats_parsed: None, }, ``` The empty stats structs causes issues with scans in datafusion. Also changed it so the writer tracking internal buffers includes the parquet writer buffering within its row group writer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…track unflushed row group size
Description
When writing a batch with the writer, if that batch would result in a flush and no more batches follow, then on close an empty parquet file (no rows) is written. This includes an Add in the log that looks like
The empty stats structs causes issues with scans in datafusion.
Also changed it so the writer tracking internal buffers includes the parquet writer buffering within its row group writer.