fix: schema comparaison in writer #1854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreDubrulle
requested review from
wjones127,
fvaleye and
roeap
as code owners
|
Add a property to the DeltaTable class to expose the table schema hash |
wjones127
reviewed
Nov 17, 2023
| ) | ||
| hash_schema_provided = _hash_schema(schema) | ||
|
|
||
| if hash_schema_provided != hash_table_schema and not ( |
There was a problem hiding this comment.
I think we should compare actual objects and not just hashes. It is still possible for hashes to collide, despite that being unlikely.
You could write a method to normalize schema order:
def normalize_schema_order(schema: pa.Schema) -> pa.Schema:
fields = sorted(iter(schema), key=lambda field: field.name)
return pa.schema(fields)And then compare those. How does that sound?
ion-elgreco
added a commit
that referenced
this pull request
Feb 25, 2024
# Description Supersedes this PR: #1854, @PierreDubrulle thanks for pointing it out # Related Issue(s) - closes #1853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving scheme comparison
Related Issue(s)