Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: introduce support for Microsoft OneLake #1642

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Sep 19, 2023

Description

This is a rebase and update of #1564 which already has some robust discussion.

Related Issue(s)

Closes #1564

@rtyler rtyler added this to the Rust v0.16 milestone Sep 19, 2023
@github-actions github-actions bot added binding/rust Issues for the Rust crate rust labels Sep 19, 2023
vmuddassir-msft and others added 2 commits September 18, 2023 21:37
This change introduces tests and support for Microsoft OneLake. This specific
commit is a rebase of the work done by our pals at Microsoft.

Co-authored-by: Mohammed Muddassir <[email protected]>
Co-authored-by: Christopher Watford <[email protected]>
…to operate

The OneLake support should be considered unsupported and experimental until such
time when we can add integration testing to our CI process
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. Would ideally like the tests run in CI and use the full test_object_store suite.

@rtyler
Copy link
Member Author

rtyler commented Sep 20, 2023

@wjones127 Me too, but the only way I think we do that is if I set up an Azure account and plonk some secrets into CI like I have done in the past for S3.

I'll think about it 😆

@rtyler rtyler merged commit d13056e into delta-io:main Sep 20, 2023
21 checks passed
@rtyler rtyler deleted the onelake-fix branch September 20, 2023 02:31
@vmuddassir-msft
Copy link
Contributor

vmuddassir-msft commented Sep 20, 2023

@rtyler - Thanks for getting this merged , since a dynamically generated jwt token is used for now it will might not be possible to store the token on Github . Can you please let me know the release date for deltalake package

https://crates.io/crates/deltalake/versions - The last update seems to have been published 2 weeks ago

@rtyler
Copy link
Member Author

rtyler commented Sep 20, 2023

@vmuddassir-msft please watch the repository's releases
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants