fix: add back original warnings

delta-io · Aug 3, 2022 · 99632b0 · 99632b0
1 parent 197386c
commit 99632b0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 42 deletions.
diff --git a/python/deltalake/deltalake.pyi b/python/deltalake/deltalake.pyi
@@ -41,9 +41,9 @@ class ArrayType:
     def from_json(json: str) -> "ArrayType": ...
     def to_pyarrow(
         self,
-    ) -> pa.DataType: ...
+    ) -> pa.ListType: ...
     @staticmethod
-    def from_pyarrow(type: pa.DataType) -> "ArrayType": ...
+    def from_pyarrow(type: pa.ListType) -> "ArrayType": ...
 
 class MapType:
     def __init__(
@@ -60,10 +60,10 @@ class MapType:
 
     def to_json(self) -> str: ...
     @staticmethod
-    def from_json(json: str) -> "ArrayType": ...
-    def to_pyarrow(self) -> pa.DataType: ...
+    def from_json(json: str) -> "MapType": ...
+    def to_pyarrow(self) -> pa.MapType: ...
     @staticmethod
-    def from_pyarrow(type: pa.DataType) -> "ArrayType": ...
+    def from_pyarrow(type: pa.MapType) -> "MapType": ...
 
 class Field:
     def __init__(
@@ -94,9 +94,9 @@ class StructType:
     def to_json(self) -> str: ...
     @staticmethod
     def from_json(json: str) -> "StructType": ...
-    def to_pyarrow(self) -> pa.DataType: ...
+    def to_pyarrow(self) -> pa.StructType: ...
     @staticmethod
-    def from_pyarrow(type: pa.DataType) -> "StructType": ...
+    def from_pyarrow(type: pa.StructType) -> "StructType": ...
 
 class Schema:
     def __init__(self, fields: List[Field]) -> None: ...

diff --git a/python/src/lib.rs b/python/src/lib.rs
@@ -1,4 +1,4 @@
-// #![deny(warnings)]
+#![deny(warnings)]
 
 extern crate pyo3;
 

diff --git a/python/tests/test_schema.py b/python/tests/test_schema.py
@@ -60,40 +60,6 @@ def test_table_schema_pyarrow_020():
     assert field.metadata is None
 
 
-# def test_schema_pyarrow_from_decimal_and_floating_types():
-#     field_name = "decimal_test"
-#     metadata = {b"metadata_k": b"metadata_v"}
-#     precision = 20
-#     scale = 2
-#     pyarrow_field = pyarrow_field_from_dict(
-#         {
-#             "name": field_name,
-#             "nullable": False,
-#             "metadata": metadata,
-#             "type": {"name": "decimal", "precision": precision, "scale": scale},
-#         }
-#     )
-#     assert pyarrow_field.name == field_name
-#     assert pyarrow_field.type == pyarrow.decimal128(precision=precision, scale=scale)
-#     assert dict(pyarrow_field.metadata) == metadata
-#     assert pyarrow_field.nullable is False
-
-#     field_name = "floating_test"
-#     metadata = {b"metadata_k": b"metadata_v"}
-#     pyarrow_field = pyarrow_field_from_dict(
-#         {
-#             "name": field_name,
-#             "nullable": False,
-#             "metadata": metadata,
-#             "type": {"name": "floatingpoint", "precision": "HALF"},
-#         }
-#     )
-#     assert pyarrow_field.name == field_name
-#     assert pyarrow_field.type == pyarrow.float16()
-#     assert dict(pyarrow_field.metadata) == metadata
-#     assert pyarrow_field.nullable is False
-
-
 def test_primitive_delta_types():
     valid_types = [
         "string",