-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable simple schema evolution for Change Data Feed #625
Open
OussamaSaoudi-db
wants to merge
23
commits into
delta-io:main
Choose a base branch
from
OussamaSaoudi-db:cdf_schema_compat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Enable simple schema evolution for Change Data Feed #625
OussamaSaoudi-db
wants to merge
23
commits into
delta-io:main
from
OussamaSaoudi-db:cdf_schema_compat
+45
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OussamaSaoudi-db
force-pushed
the
cdf_schema_compat
branch
from
January 7, 2025 21:25
2cde0da
to
a6eb6cf
Compare
OussamaSaoudi-db
changed the title
[WIP] feat: Enable simple schema evolution for Change Data Feed
[ \[WIP\] feat: Enable simple schema evolution for Change Data Feed](https://github.com/delta-io/delta-kernel-rs/pull/625/files/596aa049376d8e6c133f77bb7ae38c7d60c8cd7c..a6eb6cfc2ed9da6e8b1ada567a4449f120322997)
Jan 7, 2025
OussamaSaoudi-db
changed the title
[ \[WIP\] feat: Enable simple schema evolution for Change Data Feed](https://github.com/delta-io/delta-kernel-rs/pull/625/files/596aa049376d8e6c133f77bb7ae38c7d60c8cd7c..a6eb6cfc2ed9da6e8b1ada567a4449f120322997)
[[WIP] feat: Enable simple schema evolution for Change Data Feed
Jan 7, 2025
OussamaSaoudi-db
changed the title
[[WIP] feat: Enable simple schema evolution for Change Data Feed
[WIP] feat: Enable simple schema evolution for Change Data Feed
Jan 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
==========================================
- Coverage 84.08% 84.07% -0.02%
==========================================
Files 76 76
Lines 17526 17540 +14
Branches 17526 17540 +14
==========================================
+ Hits 14736 14746 +10
- Misses 2077 2079 +2
- Partials 713 715 +2 ☔ View full report in Codecov by Sentry. |
OussamaSaoudi-db
force-pushed
the
cdf_schema_compat
branch
from
January 7, 2025 23:34
3c7abf7
to
9fe84e8
Compare
OussamaSaoudi-db
changed the title
[WIP] feat: Enable simple schema evolution for Change Data Feed
feat: Enable simple schema evolution for Change Data Feed
Jan 7, 2025
OussamaSaoudi
force-pushed
the
cdf_schema_compat
branch
from
January 23, 2025 21:48
9fe84e8
to
a55b1ab
Compare
Add schema compatibility tests Add error-based schema compatibility check Remove old schema compat change naming, remove redundant test Improve comments, add check that field names aren't case-insensitive duplicates Change ordering, remove unnecessary comment Add comments to can_read_as methods Add schema compatibility check to CDF, update cdf tests remove todo comments Add clarifying comments
github-actions
bot
added
the
breaking-change
Change that will require a version bump
label
Jan 23, 2025
OussamaSaoudi
force-pushed
the
cdf_schema_compat
branch
from
January 23, 2025 21:58
a55b1ab
to
093f275
Compare
OussamaSaoudi
removed
merge hold
Don't allow the PR to merge
breaking-change
Change that will require a version bump
labels
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR enabled simple forms of schema evolution to change data feed. The supported schema changes are:
This PR also removes several unnecessary uses of
allow(unused)
.How was this change tested?
Updated existing tests to check that performing schema evolution check fails in these cases:
The updates to the tests also control more variables so that we test only one thing at a time.