-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emoji list to emoji v15.0. #58
base: main
Are you sure you want to change the base?
Conversation
Change emoji grouping to official grouping. Add option to customize emoji list. Change default group icon to lucide icon. Modify Header Padding to accommodate new grouping size. Modify Header flex option to fix off-center icons. Updating npm dependencies. Fix some bugs. And more...
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Hi @lushangkan Thank you for the PR; I will review the changes and merge it as soon as possible. |
Seems like I didn't handle skin tones well, I'll fix that later |
Fixed unsupported skin color issue, zwj_emoji not supported for now (except Other group) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lushangkan, thanks again for your incredible effort on this.
PR looks good, just two minor changes needed:
- You may want to update the emoji cdn URL as well in
constant.ts#L3
, the new src should behttps://cdn.jsdelivr.net/npm/[email protected]/img/apple/64/
vue3-emoji-picker/src/constant.ts
Lines 3 to 4 in c430646
export const EMOJI_REMOTE_SRC = | |
'https://cdn.jsdelivr.net/npm/[email protected]/img/apple/64' |
- In emojis.json#10461, could you please update
2642-fe0f
to2641-fe0f
? I noticed themale sign
emoji doesn't show with the previous code for some reason.
vue3-emoji-picker/src/data/emojis.json
Line 10461 in c430646
"u": "2642-fe0f" |
Thank you for checking it out! |
I think zwj emoji will be a good feature, I will need to check the possibilities. |
Modify test module to accommodate new emojis.json. Modify the emoji resource version.
Is the 2641 the ♁ symbol you are referring to? The symbol is earth symbol, deprecated in Unicode 1.1, I switched 2642 to 2641 in my device (Windows 11) and it shows up as , and I didn't find this icon in the official list of Unicode either |
I see the request https://fastly.jsdelivr.net/npm/[email protected]/img/apple/64/2642-fe0f.png failed message in the console, which could be a problem with the emoji-datasource-apple repository |
Context
Update emoji list to emoji version.
Add option to customize emoji list.
Summary
Update emoji list to emoji v15.0.
Change emoji grouping to official grouping.
Add option to customize emoji list.
Change default group icon to lucide icon.
Modify Header Padding to accommodate new grouping size.
Modify Header flex option to fix off-center icons.
Updating npm dependencies.
Fix some bugs.
And more...
To-do
User-facing changes
Too much changes. Comment it if you need.
Checklist