Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go Modules to OTEL 1.32 #177

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Update Go Modules to OTEL 1.32 #177

merged 3 commits into from
Dec 19, 2024

Conversation

HarishH-DELL
Copy link
Contributor

@HarishH-DELL HarishH-DELL commented Dec 19, 2024 •
edited
Loading

Description

Update Go Modules to OTEL 1.32 version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Run the Go mod tidy and Build Binary
  • Run the Manually test with New Image
    topology

@csmbot
Copy link
Collaborator

csmbot commented Dec 19, 2024

Can one of the admins verify this patch?

shefali-malhotra
shefali-malhotra previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chimanjain
chimanjain previously approved these changes Dec 19, 2024
View reviewed changes
chimanjain
chimanjain approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@chimanjain chimanjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shefali-malhotra shefali-malhotra merged commit 0f2e2cd into main Dec 19, 2024
8 checks passed
@shefali-malhotra shefali-malhotra deleted the user/harish/go_module_update branch December 19, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@chimanjain chimanjain chimanjain approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@YianZong YianZong Awaiting requested review from YianZong YianZong is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HarishH-DELL @csmbot @chimanjain @nitesh3108 @shefali-malhotra