Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating gofsutil version with latest release #173

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

PeresKereotubo
Copy link
Contributor

@PeresKereotubo PeresKereotubo commented Sep 19, 2023

Description

Updating karavi-resiliency gofsutil with the new release

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

Short integration test for powerflex

6 scenarios (�[32m6 passed�[0m)
60 steps (�[32m60 passed�[0m)
43m49.091590327s
time="2023-09-19T16:11:57-04:00" level=info msg="Integration test finished"
--- PASS: TestPowerFlexShortIntegration (2629.14s)
PASS
status 0
ok podmon/internal/monitor 2637.745s

Copy link
Collaborator

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the tests that were executed along with the results. Thank you.

@shaynafinocchiaro
Copy link
Contributor

@gallacher please find test results in the description.

@alikdell alikdell dismissed gallacher’s stale review September 19, 2023 20:13

6 scenarios (6 passed) 60 steps (60 passed) 41m19.218511056s INFO[2488] Integration test finished --- PASS: TestPowerFlexShortIntegration (2479.25s) PASS status 0 ok podmon/internal/monitor 2488.516s

@alikdell alikdell merged commit 181b7c3 into main Sep 19, 2023
@alikdell alikdell deleted the updating-gofsutil-version branch September 19, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants