Added support for CSI-PowerScale #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakshi-dell
requested review from
medegw01,
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro and
sharmilarama
as code owners
randeepdell
previously approved these changes
Apr 27, 2022
coulof
reviewed
Apr 28, 2022
coulof
reviewed
Apr 28, 2022
randeepdell
reviewed
May 2, 2022
| log.Infof("CSI Driver for Unity") | ||
| monitor.Driver = new(monitor.UnityDriver) | ||
| } else if strings.Contains(*args.driverPath, "isilon") { // added condition to create instance of PowerScale driver | ||
| case strings.Contains(*args.driverPath, "isilon"): | ||
| // added condition to create instance of PowerScale driver |
randeepdell
previously approved these changes
May 2, 2022
rbo54
previously approved these changes
May 2, 2022
|
@Sakshi-dell can you close the comments from Florian and we can merge this PR. |
meggm
previously approved these changes
May 4, 2022
|
@alexemc @gallacher @sharmilarama need codeowner approval to merge this PR. Please approve. |
alikdell
reviewed
May 4, 2022
|
|
||
| // FinalCleanup handles any driver specific final cleanup. | ||
| func (d *PScaleDriver) FinalCleanup(rawBlock bool, volumeHandle, pvName, podUUID string) error { | ||
| return nil |
There was a problem hiding this comment.
Any corner cases where podmon needed to cleanup. If there anything we should add here.
alikdell
approved these changes
May 4, 2022
alikdell
requested changes
May 4, 2022
Sakshi-dell
dismissed stale reviews from meggm, rbo54, and randeepdell
via
4f1918c
alikdell
approved these changes
May 9, 2022
randeepdell
approved these changes
May 9, 2022
rbo54
approved these changes
May 9, 2022
|
|
||
| // GetStagingMountDir Returns the staging directory used by NodeUnstage for a mount device. | ||
| func (d *PScaleDriver) GetStagingMountDir(volumeHandle, pvName string) string { | ||
| return "" |
There was a problem hiding this comment.
Is there not a separate staging directory? What do you expect to be passed as the staging directory to node unstage?
There was a problem hiding this comment.
PowerScale does not have a separate staging path, we have not implemented NodeStage/NodeUnstage Volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Unit-test Output
PASS
coverage: 92.6% of statements
status 0
ok podmon/internal/monitor 8.603s coverage: 92.6% of statements