Update privateMountDir path for unity nfs #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikdell
requested review from
medegw01,
gallacher,
tdawe,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
LJ-Software and
sharmilarama
as code owners
shaynafinocchiaro
approved these changes
Mar 14, 2022
rbo54
approved these changes
Mar 14, 2022
| @@ -94,12 +94,12 @@ Feature: Integration Test | |||
| Examples: | |||
| | kubeConfig | podsPerNode | nVol | nDev | driverType | storageClass | workers | primary | failure | failSecs | deploySecs | runSecs | nodeCleanSecs | | |||
| # Small number of pods, increasing number of vols and devs | |||
| | "" | "1-2" | "1-1" | "1-1" | "unity" | "unity-iscsi" | "one-third" | "zero" | "interfacedown" | 240 | 900 | 900 | 900 | | |||
| | "" | "1-2" | "1-1" | "1-1" | "unity" | "unity-iscsi" | "one-third" | "zero" | "interfacedown" | 600 | 900 | 900 | 900 | | |||
There was a problem hiding this comment.
I don't understand why your changing some examples failSecs but not others. It seems arbitrary. Are these the ones you observer failures on?
There was a problem hiding this comment.
I changed for unity alone.
Secondly under unity if I haven't changed, those are commented examples that we needed to clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update privateMountDir path for unity nfs. This PR has following changes
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration