Support for NoExecute taint, pod affinity, and bug fix volume attachment delete #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d processing SkipArrayConnectionCheck only on a node noexec taint.
…rnate way to kill node
…e nodes with 110 pods)
rbo54
requested review from
alikdell,
atye,
coulof,
gallacher,
hoppea2,
LJ-Software,
medegw01,
sharmilarama,
shaynafinocchiaro and
tdawe
as code owners
|
I will fix the forbidden words with a grep of 'mast.r' instead of what kubernetes calls them. |
tdawe
reviewed
Jan 21, 2022
Update changes from main into this branch.
hoppea2
changed the title
alikdell
previously approved these changes
Jan 24, 2022
shaynafinocchiaro
previously approved these changes
Jan 25, 2022
tdawe
previously approved these changes
Jan 25, 2022
sharmilarama
previously approved these changes
Jan 25, 2022
alikdell
reviewed
Jan 25, 2022
| @@ -403,6 +454,23 @@ func (cm *PodMonitorType) ArrayConnectivityMonitor() { | |||
| } | |||
| } | |||
|
|
|||
| // ProcessPodInfoForCleanup processes a ControllerPodInfo for cleanup, checking that the UID and object are the same, and then calling controllerCleanupPod. | |||
| func (cm *PodMonitorType) ProcessPodInfoForCleanup(podInfo *ControllerPodInfo, reason string) { | |||
There was a problem hiding this comment.
This func is not required to expose!
rbo54
dismissed stale reviews from sharmilarama, tdawe, shaynafinocchiaro, and alikdell
via
18e5e12
|
I have updated the PR, addressing Trevor's concern. I have run full integration test for VxFlex and Unity, both passed. Unit test still also passing. |
alikdell
previously approved these changes
Jan 26, 2022
shaynafinocchiaro
previously approved these changes
Jan 26, 2022
tdawe
previously approved these changes
Jan 26, 2022
rbo54
dismissed stale reviews from tdawe, shaynafinocchiaro, and alikdell
via
fe24a65
rbo54
force-pushed
the
tom/KRV-2608-1662
branch
from
18e5e12 to
fe24a65
Compare
alikdell
approved these changes
Jan 26, 2022
shaynafinocchiaro
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains:
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
184 steps (184 passed)
1h33m23.697942654s
time="2022-01-20T20:18:43-05:00" level=info msg="Integration test finished"
--- PASS: TestPowerFlexIntegration (5603.73s)
PASS