Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support yaml and skipCertificateValidation in secret parsing #116

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

tdawe
Copy link
Collaborator

@tdawe tdawe commented Dec 14, 2021

Description

Updated the secret parsing:

  • Supports either yaml or json
  • Added the new key for skipCertificateValidation

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#137

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • E2E tests passed ok karavi-testing/karavi-metrics/metrics-test 110.532s

@tdawe
Copy link
Collaborator Author

tdawe commented Dec 15, 2021

run e2e test

@tdawe
Copy link
Collaborator Author

tdawe commented Dec 15, 2021

run e2e test

Manual e2e tests were successful:

# go test --count 1 --timeout 15m ./...                        # karavi-testing/karavi-metrics/metrics-util
ok      karavi-testing/karavi-metrics/metrics-test      110.532s

@tdawe tdawe merged commit 99b9440 into main Dec 15, 2021
@tdawe tdawe deleted the update-secret-parsing branch December 15, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants