Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the storage system secret earlier with default value #65

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Create the storage system secret earlier with default value #65

merged 1 commit into from
Mar 26, 2021

Conversation

ianbibby
Copy link
Contributor

Description

This PR addresses a timing issue where the storage system K8s secret is not ready before the proxy server comes up.

Issues

List the issues impacted by this PR:

Issue ID
https://github.com/dell/karavi-authorization/issues/10

Checklist:

  • I have performed a self-review of my own changes.

AronAtDell
AronAtDell approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@AronAtDell AronAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should address initialization of the list. Looks good.

@ianbibby ianbibby merged commit c801e49 into main Mar 26, 2021
@ianbibby ianbibby deleted the fix-storagesystem-secret branch March 26, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell approved these changes

@AronAtDell AronAtDell AronAtDell approved these changes

@LJ-Software LJ-Software LJ-Software approved these changes

@tdawe tdawe tdawe approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@medegw01 medegw01 Awaiting requested review from medegw01

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ianbibby @tdawe @LJ-Software @AronAtDell @alikdell