Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-1347]: Prompt for storage system password when creating storage #284

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

atye
Copy link
Contributor

@atye atye commented Jun 27, 2024

Description

Add storage system password prompt when creating storage if password flag is not provided.

karavictl storage create --type powerflex --endpoint https://powerflex.com --system-id 0123456789 --user admin --admin-token admin.yaml --insecure --addr csm-authorization.com --array-insecure
Enter password for https://[email protected]:

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1347

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

New unit test. Manual testing with real storage system.

@atye
Copy link
Contributor Author

atye commented Jun 27, 2024

e2e pass

@atye atye merged commit 4113762 into main Jun 27, 2024
8 checks passed
@atye atye deleted the bug-1347-karavictl-storage-password branch June 27, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants