Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement docker multi stage build and use common Go image #265

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Feb 19, 2024

Description

Implement docker multi stage build to build module and use common Go image for building module.
Also update github actions.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Build module image and ran sanity test

Screenshot 2024-02-19 194001

@csmbot
Copy link
Collaborator

csmbot commented Feb 19, 2024

Can one of the admins verify this patch?

Makefile Show resolved Hide resolved
@atye
Copy link
Contributor

atye commented Feb 21, 2024

run e2e test

@tdawe
Copy link
Collaborator

tdawe commented Feb 21, 2024

e2e pass

1 similar comment
@atye
Copy link
Contributor

atye commented Feb 21, 2024

e2e pass

@KerryKovacevic KerryKovacevic merged commit 0fa115f into main Feb 21, 2024
7 of 8 checks passed
@KerryKovacevic KerryKovacevic deleted the multi-stage-build branch February 21, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants