Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-767]: karavictl generate token outputs yaml #230

Merged
merged 5 commits into from
Apr 24, 2023

Conversation

atye
Copy link
Contributor

@atye atye commented Apr 21, 2023

Description

karavictl generate token outputs yaml that can be applied to k8s without any processing.

# karavictl generate token --tenant PancakeGroup --admin-token <file> --insecure --addr <address>
apiVersion: v1
data:
  access: ZXlKaGJHY2lPaUpJVXpJMU5pSXNJblI1Y0NJNklrcFhWQ0o5LmV5SmhkV1FpT2lKamMyMGlMQ0psZUhBaU9qRTJPREl3T1RBM09EVXNJbWR5YjNWd0lqb2lVR0Z1WTJGclpVZHliM1Z3SWl3aWFYTnpJam9pWTI5dExtUmxiR3d1WTNOdElpd2ljbTlzWlhNaU9pSkRVMGxUYVd4MlpYSXNRMU5KUjI5c1pDSXNJbk4xWWlJNkltTnpiUzEwWlc1aGJuUWlmUS44dG9mdGg0M2V1ZU8wcDY4dEp3MS0tVXVDYXlrMXhuNXhkekRXNFJSMXpj
  refresh: ZXlKaGJHY2lPaUpJVXpJMU5pSXNJblI1Y0NJNklrcFhWQ0o5LmV5SmhkV1FpT2lKamMyMGlMQ0psZUhBaU9qRTJPRFEyT0RJM01qVXNJbWR5YjNWd0lqb2lVR0Z1WTJGclpVZHliM1Z3SWl3aWFYTnpJam9pWTI5dExtUmxiR3d1WTNOdElpd2ljbTlzWlhNaU9pSkRVMGxUYVd4MlpYSXNRMU5KUjI5c1pDSXNJbk4xWWlJNkltTnpiUzEwWlc1aGJuUWlmUS53SzlXYlZ3YVlKcEFOamxqcnh2bjhkcE5tOGVXR2Z0RUhsQmFoVVd0bkhR
kind: Secret
metadata:
  creationTimestamp: null
  name: proxy-authz-tokens
type: Opaque

Also removes superfluous response.writeheader calls.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#767

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Existing unit tests and manual tests.

alikdell
alikdell previously approved these changes Apr 21, 2023
xuluna
xuluna previously approved these changes Apr 21, 2023
@atye atye dismissed stale reviews from xuluna and alikdell via 872fd09 April 21, 2023 19:59
@atye atye force-pushed the bug-767-generate-token-yaml branch from fd83ab5 to 872fd09 Compare April 21, 2023 19:59
sharmilarama
sharmilarama previously approved these changes Apr 21, 2023
@dell dell deleted a comment from sharmilarama Apr 21, 2023
@atye atye closed this Apr 21, 2023
@atye atye reopened this Apr 21, 2023
@atye
Copy link
Contributor Author

atye commented Apr 21, 2023

run e2e test

@atye atye dismissed stale reviews from sharmilarama and shaynafinocchiaro via d408bdf April 22, 2023 02:39
@atye atye force-pushed the bug-767-generate-token-yaml branch from 872fd09 to d408bdf Compare April 22, 2023 02:39
@atye
Copy link
Contributor Author

atye commented Apr 24, 2023

e2e pass

@atye atye merged commit 2cbc4e3 into main Apr 24, 2023
@atye atye deleted the bug-767-generate-token-yaml branch April 24, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants