Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerflex pre-approved GUIDs #216

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Powerflex pre-approved GUIDs #216

merged 2 commits into from
Feb 28, 2023

Conversation

ashleyvjoy
Copy link
Contributor

@ashleyvjoy ashleyvjoy commented Feb 28, 2023

Description

  • The sdcApproveHandler will allow/deny approve SDC request coming from driverside to the powerflex array based on the Tenant data
  • A new approvesdc boolean flag(default value is true) is added to karavictl tenant create
  • A new karavictl tenant update command to update the approvesdc flag value
  • karavictl tenant get updated

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| dell/csm#402 |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Powerflex-Authorization-results
 13 scenarios (�[32m13 passed�[0m)
         99 steps (�[32m99 passed�[0m)
         9m33.634408546s
         2023/02/27 16:51:27 Volume test finished
         --- PASS: TestVolume (573.70s)
  • Powerscale-Authrization-results
  3 scenarios (�[32m3 passed�[0m)
         27 steps (�[32m27 passed�[0m)
         6m22.379388472s
         2023/02/28 02:55:58 Volume test finished
          --- PASS: TestVolume (382.42s)

@csmbot
Copy link
Collaborator

csmbot commented Feb 28, 2023

Can one of the admins verify this patch?

@dell dell deleted a comment from atye Feb 28, 2023
@sharmilarama
Copy link
Collaborator

e2e pass

@ashleyvjoy ashleyvjoy merged commit 4bbef3b into main Feb 28, 2023
@anandrajak1 anandrajak1 deleted the approvesdc-poc branch October 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants