Usr/rodrigo bassil/traefikv2 #209
Conversation
rodrigobassil
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov,
bjiang27,
IsaiasA1,
aqu-dell and
xuluna
as code owners
|
Can one of the admins verify this patch? |
|
We need a GH CSM issue, I am working on it, will update this PR when we have one. |
Done. updated. |
|
|
||
| if [ $($K3S kubectl get svc -n kube-system | grep traefik | wc -l) -eq 1 ] | ||
| then | ||
| sh ./traefik_nodeport.sh --traefik_web_port $webPort --traefik_websecure_port $websecurePort |
There was a problem hiding this comment.
Is there a need to have a separate script? Since the inputs for this configuration are already defined in this script , may just want to call a function here.
There was a problem hiding this comment.
@sharmilarama, the intent here is to give more flexibility to customers. In case customers forget to set the Nodeports during installation/upgrade, they can do it in a later stage using traefik_nodeport.sh. Also, it gives the possibility to change the Nodeports in a later stage without having to touch any other configuration.
|
@rodrigobassil can you take the PR out of draft mode? |
|
run e2e test |
Description
GitHub Issues
List the GitHub issues impacted by this PR:
| GitHub Issue # |
| dell/csm#642 |
| |
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration